fix(inheritance-report): bugfixing 20.12

[albinagu]

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Introduced an enabled property for various asset types including bank accounts, claims, and stocks.
  • Updated the asset representation by replacing propertyValuation with amount in relevant sections.

• Bug Fixes

  • Enhanced schema validation logic to accommodate new fields and ensure data integrity.

• Documentation

  • Updated data schema to reflect changes in asset structure and validation requirements.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the mappers.ts and dataSchema.ts files within the inheritance report module. The changes primarily focus on standardizing the data structure for various assets by adding an enabled property and renaming the propertyValuation field to amount. These updates ensure a more consistent and flexible representation of asset data, with default values being introduced for new properties while maintaining the existing logic of the transformation functions.

Changes

File	Change Summary
libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/utils/mappers.ts	- Added enabled property with default true for various assets (bank accounts, claims, guns, real estate, stocks, vehicles) - Replaced propertyValuation with amount in bank accounts mapping
libs/application/templates/inheritance-report/src/lib/dataSchema.ts	- Renamed propertyValuation to amount in bankAccounts and claims sections - Added enabled: z.boolean() for bankAccounts, claims, and stocks sections

Suggested labels

deploy-feature

Suggested reviewers

• kksteini
• juni-haukur

Possibly related PRs

• fix(inheritance-report): EFS fixes 4.06 #15097: Modifies expandAnswers function by adding applicationFor field.
• fix(inheritance-report): EFS fixes 6/06 #15132: Updates dataSchema.ts with refinement for amount field.
• fix(inheritance-report): EFS touch ups #15161: Introduces enabled property in assets section.
• fix(inheritance-report): adding service to mappers #17177: Adds service property to funeralCost object.
• fix(inheritance-report): Fixes for go live #17295: Modifies expandAnswers to include enabled property for asset types.

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d1d63e and 9cafe74.

📒 Files selected for processing (2)

• libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/utils/mappers.ts (3 hunks)
• libs/application/templates/inheritance-report/src/lib/dataSchema.ts (3 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 35.69%. Comparing base (0d1d63e) to head (9cafe74).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ules/templates/inheritance-report/utils/mappers.ts	0.00%	4 Missing ⚠️
...templates/inheritance-report/src/lib/dataSchema.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17322      +/-   ##
==========================================
- Coverage   35.69%   35.69%   -0.01%     
==========================================
  Files        6928     6928              
  Lines      148730   148733       +3     
  Branches    42495    42498       +3     
==========================================
  Hits        53087    53087              
- Misses      95643    95646       +3     

Flag	Coverage Δ
api	3.33% <ø> (ø)
application-system-api	38.74% <0.00%> (+<0.01%)	⬆️
application-template-api-modules	27.68% <0.00%> (-0.01%)	⬇️
application-templates-inheritance-report	6.59% <0.00%> (ø)
application-ui-shell	22.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...templates/inheritance-report/src/lib/dataSchema.ts	0.00% <0.00%> (ø)
...ules/templates/inheritance-report/utils/mappers.ts	2.87% <0.00%> (-0.06%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1d63e...9cafe74. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs c868bed 🔗

✅ 4 Total Test Services: 0 Failed, 4 Passed
➡️ Test Sessions change in coverage: 8 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	2.4s	1 no change	Link
application-system-api	0	0	0	46	0	2m 9.56s	1 no change	Link
application-template-api-modules	0	0	0	118	0	2m 7.47s	1 no change	Link
application-ui-shell	0	0	0	74	0	32.01s	1 no change	Link