Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(criminal record): Fix email to Syslumenn #17341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −22
Open

fix(criminal record): Fix email to Syslumenn #17341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...rc/lib/modules/templates/criminal-record-submission/criminal-record-submission.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@ import { Injectable } from '@nestjs/common'
import { SharedTemplateApiService } from '../../shared'
import { TemplateApiModuleActionProps } from '../../../types'
import { CriminalRecordService } from '@island.is/api/domains/criminal-record'
import {
SyslumennService,
Person,
PersonType,
} from '@island.is/clients/syslumenn'
import { SyslumennService, PersonType } from '@island.is/clients/syslumenn'
import {
ApplicationTypes,
ApplicationWithAttachments as Application,
Expand Down
6 changes: 1 addition & 5 deletions .../lib/modules/templates/criminal-record-submission/emailGenerators/syslumennNotifyError.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { EmailTemplateGenerator } from '../../../../types'
import { NationalRegistry } from '../types'

export const generateSyslumennNotifyErrorEmail: EmailTemplateGenerator = (
props,
Expand All @@ -11,12 +10,9 @@ export const generateSyslumennNotifyErrorEmail: EmailTemplateGenerator = (

const syslumennEmail = '[email protected]'

const nationalRegistryData = application.externalData.nationalRegistry
?.data as NationalRegistry

const subject = 'Umsókn um sakavottorð'
const body = `
Villa hefur komið upp í samskiptum milli island.is og sýslumanna, vegna kaupa á sakavottorði fyrir ${nationalRegistryData.nationalId}.
Villa hefur komið upp í samskiptum milli island.is og sýslumanna, vegna kaupa á sakavottorði fyrir ${application.applicant}.
`

return {
Expand Down
12 changes: 0 additions & 12 deletions libs/application/templates/criminal-record/src/lib/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,6 @@ export const m = defineMessages({
defaultMessage: 'Ég hef kynnt mér ofangreint',
description: 'I understand',
},
nationalRegistryTitle: {
id: 'cr.application:nationalRegistry.title',
defaultMessage: 'Persónuupplýsingar úr Þjóðskrá',
description: 'Personal information from the National Registry',
},
nationalRegistrySubTitle: {
id: 'cr.application:nationalRegistry.subTitle',
defaultMessage:
'Til þess að auðvelda fyrir sækjum við persónuupplýsingar úr Þjóðskrá til þess að fylla út umsóknina',
description:
'Information from the National Registry will be used to prefill the data in the application',
},
userProfileInformationTitle: {
id: 'cr.application:userprofile.title',
defaultMessage: 'Netfang og símanúmer úr þínum stillingum',
Expand Down
Loading