fix(application-inheritance-report): Fetch s3 filename from correct location #17350
Conversation
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options. WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportAll test runs ✅ 3 Total Test Services: 0 Failed, 3 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/inheritance-report.service.ts (3)
117-122: Consider adding a fallback or error handling for missing attachment keys.If application.attachments does not contain file.key as an entry, filename will be undefined and can disrupt getFileContentBase64. Adding a quick check or fallback could improve resiliency.
136-141: Apply the same missing key fallback strategy here.This code mirrors the logic above. If file.key doesn't exist in application.attachments, filename is undefined, leading to potential errors. Consistency in error handling here will help avoid unexpected failures.
191-194: Correct the spelling of "inheritance-report" in the log prefix.The logger message prefix "[inherhitance-report]" has a spelling issue ("inherhitance" → "inheritance"). Fixing this will maintain consistency in log outputs.
Apply this quick fix:
- '[inherhitance-report]: Failed to get file content - ', + '[inheritance-report]: Failed to get file content - ',
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/inheritance-report.service.ts(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
libs/application/template-api-modules/src/lib/modules/templates/inheritance-report/inheritance-report.service.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
…ocation (#17350) * fetch filename from correct location * remove console log --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
...
Attach a link to issue if relevant
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit