fix(web): Change search filter

[thorkellmani]

What

• Switch filter mobile mode from popover -> dialog

Why

• Dialog seems to be more commonly used in web

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Enhanced search results display with total hits count
  • Updated filter interface for mobile devices

• Localization

  • Added new localized message for viewing search results in Icelandic

• Improvements

  • Refined search results filter component with dynamic hit counting

[coderabbitai]

Walkthrough

The pull request introduces modifications to the Grants search results functionality across multiple files. The primary changes involve adding a hits prop to the GrantsSearchResultsFilter component, updating the mobile filter variant, and introducing a new localization message for viewing results. These updates enhance the search results display by dynamically showing the number of hits and adjusting the filter interface presentation.

Changes

File	Change Summary
apps/web/screens/Grants/SearchResults/SearchResults.tsx	- Added hits: totalHits prop to GrantsSearchResultsFilter - Changed mobile filter variant from 'popover' to 'dialog'
apps/web/screens/Grants/SearchResults/SearchResultsFilter.tsx	- Added optional hits prop to Props interface - Modified labelResult to use new viewResults message - Set resultCount to hits
apps/web/screens/Grants/messages.ts	- Added new viewResults message with Icelandic text "Skoða niðurstöður"

Possibly related PRs

• fix(web-grants): Tag descriptions #16941: Modifies GrantsSearchResultsFilter component to include hits prop
• feat(web): updated grant status logic #17127: Introduces parseStatus function for grant status handling
• fix(web): grants translations #17641: Updates routing logic for grants-related pages

Suggested labels

automerge, deploy-feature

Suggested reviewers

• RunarVestmann
• disaerna

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4c8d9e and cff9bdf.

📒 Files selected for processing (3)

• apps/web/screens/Grants/SearchResults/SearchResults.tsx (2 hunks)
• apps/web/screens/Grants/SearchResults/SearchResultsFilter.tsx (3 hunks)
• apps/web/screens/Grants/messages.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

apps/web/screens/Grants/SearchResults/SearchResultsFilter.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

apps/web/screens/Grants/messages.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

apps/web/screens/Grants/SearchResults/SearchResults.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

🔇 Additional comments (5)

apps/web/screens/Grants/messages.ts (1)

115-118: LGTM! The new message follows the established conventions.

The new viewResults message maintains consistency with the existing message structure and naming conventions.

apps/web/screens/Grants/SearchResults/SearchResults.tsx (2)

294-294: LGTM! Consistent prop passing in desktop view.

The hits prop is correctly passed to the filter component, maintaining consistency with the mobile view.

---

363-364: LGTM! Mobile view updates align with PR objectives.

The changes appropriately:

1. Switch to dialog variant for better mobile UX
2. Pass the hits prop consistently with desktop view

apps/web/screens/Grants/SearchResults/SearchResultsFilter.tsx (2)

32-32: LGTM! Proper type definition.

The optional hits prop is correctly typed as number.

---

72-73: LGTM! Proper usage of the new message and hits count.

The Filter component correctly:

1. Uses the new viewResults message for the label
2. Passes the hits count to display result count

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.