Revert "fix(core): Handle SIGTERM for graceful shutdowns"

[busla]

Reverts #16882

Reason:

Runs:
https://github.com/island-is/island.is/actions/runs/13076250951/job/36489504132

...
 libs/application/templates/inao/financial-statement-individual-election/project.json
- All tags should be the same
NX tags: [ 'lib:js', 'scope:application-system' ] 

libs/api/domains/auth-admin/project.json
- All tags should be the same
NX tags: [ 'scope:*', 'lib:api' ] 

Found errors in project files
All projects should have a configured NX tags which controls which project can import what.
For more information see: https://docs.devland.is/repository/nx-tags
Invalid projects: [ 'libs/node/utils/project.json' ]

https://github.com/island-is/island.is/actions/runs/13076250951/job/36489504132

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request involves the removal of shutdown hooks functionality across multiple libraries and configuration files. The changes primarily focus on eliminating the setupShutdownHooks utility from the libs/node/utils directory and related configurations. Several server-related files in different libraries have been modified to remove references to shutdown hooks, including Express, Nest, and Next server configurations. The project's TypeScript configuration has also been updated to remove path mappings for the now-deleted utility.

Changes

File	Change Summary
libs/infra-express-server/src/lib/infra-express-server.ts	Syntax updates to route handlers and middleware functions
libs/infra-nest-server/src/lib/bootstrap.ts	Removed app.enableShutdownHooks()
libs/infra-next-server/src/lib/bootstrap.ts	Added setupExitHook function, simplified server startup
libs/node/utils/	Entire directory and its configuration files deleted
tsconfig.base.json	Removed path mapping for @island.is/node-utils

Possibly related PRs

• fix(core): Handle SIGTERM for graceful shutdowns #16882: Introduced original setupShutdownHooks functionality
• chore(ci): revert: Use DOCKER_REGISTRY, and compat" #17057: Reverted Docker registry handling changes
• feat(j-s): Allow multiple subtypes in indictments #17192: Enhanced indictment handling logic

Suggested Labels

automerge, dirty bypass

Suggested Reviewers

• lodmfjord
• eirikurn

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80377e1 and 29fce58.

📒 Files selected for processing (14)

• libs/infra-express-server/src/lib/infra-express-server.ts (2 hunks)
• libs/infra-nest-server/src/lib/bootstrap.ts (0 hunks)
• libs/infra-next-server/src/lib/bootstrap.ts (1 hunks)
• libs/node/utils/.eslintrc.json (0 hunks)
• libs/node/utils/README.md (0 hunks)
• libs/node/utils/jest.config.ts (0 hunks)
• libs/node/utils/project.json (0 hunks)
• libs/node/utils/src/index.ts (0 hunks)
• libs/node/utils/src/lib/setupShutdownHooks.spec.ts (0 hunks)
• libs/node/utils/src/lib/setupShutdownHooks.ts (0 hunks)
• libs/node/utils/tsconfig.json (0 hunks)
• libs/node/utils/tsconfig.lib.json (0 hunks)
• libs/node/utils/tsconfig.spec.json (0 hunks)
• tsconfig.base.json (0 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 29fce58.

Command	Status	Duration	Result
nx run-many --target=lint --projects=infra-expr...	✅ Succeeded	1m 7s	View ↗
nx run-many --target=build --projects=judicial-...	✅ Succeeded	3m 27s	View ↗
nx run-many --projects user-monitoring --target...	✅ Succeeded	<1s	View ↗
nx run-many --projects skilavottord-web --targe...	✅ Succeeded	1s	View ↗
nx run-many --projects university-gateway --tar...	✅ Succeeded	1s	View ↗
nx run-many --projects web --target test --para...	✅ Succeeded	1s	View ↗
nx run-many --target=codegen/frontend-client --...	✅ Succeeded	12s	View ↗
nx run-many --projects testing-containers,testi...	✅ Succeeded	1s	View ↗
Additional runs (82)	✅ Succeeded	...	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-02-01 01:42:02 UTC