fix(parental-leave): Don't show spouse name if other parent is input manually

[ylfahfa]

Don't show spouse name if other parent is input manually

What

Check if other parent was input manually

Why

So we don't show spouse name when parent is having a child with non-spouse

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Bug Fixes
  • Improved the parental leave application so that when manually entered details are provided for the other parent, they are now correctly displayed. This update enhances the accuracy of parental information shown in various scenarios.

[coderabbitai]

Walkthrough

The changes update the conditional logic in the getOtherParentName function within the parental leave template. Specifically, an additional condition checks if the otherParent value is MANUAL, which results in returning the otherParentName even when a spouse exists without a name. The function signature remains unchanged.

Changes

File	Change Summary
libs/.../parentalLeaveUtils.ts	Modified getOtherParentName to include a check for otherParent === MANUAL, altering the decision logic for returning the otherParentName based on available data.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant F as getOtherParentName
    C->>F: Call getOtherParentName(application)
    F->>F: Retrieve spouse and otherParent data
    alt Spouse is missing or has no name OR otherParent == MANUAL
        F-->>C: Return otherParentName
    else
        F-->>C: Return spouse name
    end

Loading

Possibly related PRs

• fix(parental-leave): Employer approval set before application approved #14815: Addresses related modifications in the parentalLeaveUtils.ts file by adjusting functions, establishing a code-level connection with the current changes.

Suggested labels

automerge

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f250f8 and c0e6ecb.

📒 Files selected for processing (1)

• libs/application/templates/parental-leave/src/lib/parentalLeaveUtils.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`libs/**/*`: "Confirm that the code adheres to the following...

libs/**/*: "Confirm that the code adheres to the following:

• Reusability of components and hooks across different NextJS apps.
• TypeScript usage for defining props and exporting types.
• Effective tree-shaking and bundling practices."

• libs/application/templates/parental-leave/src/lib/parentalLeaveUtils.ts

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: tests (application-system-form,application-template-api-modules,application-template-loader,appli...
• GitHub Check: tests (application-system-api)

🔇 Additional comments (1)

libs/application/templates/parental-leave/src/lib/parentalLeaveUtils.ts (1)

1267-1267: LGTM! The fix correctly handles manual parent input.

The additional condition otherParent === MANUAL ensures that manually entered parent names take precedence over spouse names, which aligns with the PR objective and prevents potential confusion.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit c0e6ecb.

Command	Status	Duration	Result
nx run-many --projects application-system-api -...	✅ Succeeded	14m 32s	View ↗
nx run-many --projects application-system-form,...	✅ Succeeded	8m 19s	View ↗
nx run-many --target=build --projects=api --par...	✅ Succeeded	4m 52s	View ↗
nx run-many --target=build --projects=applicati...	✅ Succeeded	3m 35s	View ↗
nx run-many --target=build --projects=applicati...	✅ Succeeded	2m 35s	View ↗
nx run-many --target=build --projects=system-e2...	✅ Succeeded	6s	View ↗
nx run-many --projects api,api-domains-applicat...	✅ Succeeded	12s	View ↗
nx run-many --target=lint --projects=applicatio...	✅ Succeeded	9s	View ↗
Additional runs (2)	✅ Succeeded	...	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-02-24 15:42:17 UTC

[birkirkristmunds]

LGTM!