feat(ids-auth-api): Make SASS Úrgangstorg delegation for companies only

[jonarnarbriem]

...

Requested by SASS

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Expanded delegation configuration with a new scope that supports additional delegation types for both procuration holder and custom scenarios. This enhancement, while not currently in use, prepares the system for potential future functionality.

[coderabbitai]

Walkthrough

A new scope rule entry was added to the delegation configuration in the auth-api-lib. The update defines a custom scope named @sass.is/urgangstorg-sveitarfelag, which is applicable only for the delegation types AuthDelegationType.ProcurationHolder and AuthDelegationType.Custom. A comment notes that the scope is currently not in use, which justifies the use of a plain string rather than an enum.

Changes

File	Change Summary
libs/.../delegations/DelegationConfig.ts	Added new entry to customScopeRules with scopeName: '@sass.is/urgangstorg-sveitarfelag' for delegation types ProcurationHolder and Custom.

Possibly related PRs

• feat(ids-auth): adding @skagafjordur.is/ibuagatt to delegation config #14913: Involves adding a new scope configuration to customScopeRules with a different scope name using similar delegation types.
• feat(ids-api): remove delegation config for ver applications #15081: Modifies the customScopeRules array by removing an existing entry, directly affecting the same configuration structure.

Suggested labels

automerge

Suggested reviewers

• saevarma
• Herdismaria

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e5e497 and 9f844bf.

📒 Files selected for processing (1)

• libs/auth-api-lib/src/lib/delegations/DelegationConfig.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`libs/**/*`: "Confirm that the code adheres to the following...

libs/**/*: "Confirm that the code adheres to the following:

• Reusability of components and hooks across different NextJS apps.
• TypeScript usage for defining props and exporting types.
• Effective tree-shaking and bundling practices."

• libs/auth-api-lib/src/lib/delegations/DelegationConfig.ts

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: prepare / install

🔇 Additional comments (1)

libs/auth-api-lib/src/lib/delegations/DelegationConfig.ts (1)

97-104: LGTM: New scope rule for SASS Úrgangstorg is correctly implemented.

The addition of the @sass.is/urgangstorg-sveitarfelag scope follows the established pattern of other custom scope rules in the file. The scope is properly restricted to ProcurationHolder (company owners) and Custom delegation types, which aligns with the PR objective to make SASS Úrgangstorg delegation for companies only.

The comment explaining the use of a plain string instead of an enum is appropriate and consistent with similar scope definitions.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 9f844bf.

Command	Status	Duration	Result
nx run-many --projects application-system-api -...	✅ Succeeded	14m 40s	View ↗
nx run-many --projects services-auth-admin-api ...	✅ Succeeded	9m 29s	View ↗
nx run-many --projects services-auth-delegation...	✅ Succeeded	8m 38s	View ↗
nx run-many --projects application-template-api...	✅ Succeeded	8m 4s	View ↗
nx run-many --projects services-auth-ids-api,se...	✅ Succeeded	6m 30s	View ↗
nx run-many --target=build --projects=api --par...	✅ Succeeded	5m 43s	View ↗
nx run-many --target=build --projects=applicati...	✅ Succeeded	4m 31s	View ↗
nx run-many --target=build --projects=services-...	✅ Succeeded	2m 27s	View ↗
Additional runs (10)	✅ Succeeded	...	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-02-25 15:26:55 UTC