Translatable object name in success message #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 29, 2016 22:58
Replaced `singular_name()` with `i18n_singular_name()` for translatable object names. These are now easily translatable with .yml files.
Shows only the DataObject name instead of both DataObject name + Record name
| 'name' => $object->singular_name(), | ||
| 'link' => $link | ||
| 'name' => $object->i18n_singular_name(), | ||
| 'link' => '' |
There was a problem hiding this comment.
Why has this been removed? If we're removing it can we remove the {link} field and delete the array key?
There was a problem hiding this comment.
This _t() function refers to GridFieldDetailForm.Saved in the framework lang file framework/lang/nl.yml which has this value:
Saved: '{name} {link} opgeslagen'
The translation file is expecting a {link} so completely removing 'link' => $link from the array would leave a meaningless DataObject saved {link} in the success-message, whereas an empty value for 'link' doesn't leave any marks. If we would remove {link} from the array we would need to remove it from each and every framework lang file which isn't desired obviously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
singular_name()withi18n_singular_name()for translatable object names. These are now easily translatable with .yml files.