generate client pointer param types #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykWalach
force-pushed
the
generate-client-pointer-param-types
branch
from
1ada565 to
3c31a60
Compare
rbalicki2
approved these changes
Feb 25, 2025
| TClientTypeSelectionLinkedFieldAssociatedData, | ||
| TClientTypeVariableDefinitionAssociatedData: Ord + Debug, | ||
| TOutputFormat: OutputFormat, | ||
| > |
There was a problem hiding this comment.
weird rust fmt behavior ! Anyway, all good (it's formatting it), just surprising
| >, | ||
| > | ||
| { | ||
| pub fn description(&self) -> Option<DescriptionValue> { |
There was a problem hiding this comment.
let's at some point consolidate these into an interface, so that e.g. the second param here can be ClientField or ClientType and we still have a .description method
| VariableDefinitionInnerType, | ||
| TOutputFormat, | ||
| > = FieldType< | ||
| &'a SchemaServerField< |
There was a problem hiding this comment.
it makes me sad that SchemaServerField is both linked and scalar :/ We should eventually fix that #436
| associated_data: &isograph_schema::ServerFieldTypeAssociatedData< | ||
| TypeAnnotation<isograph_lang_types::ServerObjectId>, | ||
| >, | ||
| name_or_alias: FieldNameOrAlias, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of client pointers #53