New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IDB interface #104

Open

qucumbah wants to merge 4 commits into isomorphic-git:main from qucumbah:remove-constructor-from-idb-interface

qucumbah commented Oct 20, 2022 •

edited

Loading

Remove constructor
Interfaces shouldn't specify constructor types.
Moreover, I'm pretty sure it's not possible to implement this interface.
Provided correct argument/return value types to the interface methods.
Fixed readFile method name.

qucumbah added 2 commits

October 20, 2022 17:44


          remove constructor from IDB interface

cfac30c


          fix method signatures of IDB interface

e324940

qucumbah changed the title ~~Remove constructor from IDB interface~~ Fix IDB interface

qucumbah added 2 commits

October 20, 2022 20:01


          fix readFile method name

da1c4c1


          fix readFile, writeFile types

84f3a8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet