-
Notifications
You must be signed in to change notification settings - Fork 63
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make release tag pattern not prefixed with 'v'.
Signed-off-by: Jianfei Hu <[email protected]>
- Loading branch information
Showing
2 changed files
with
23 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28404a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dio oops, sorry, I was intended to do a PR instead, but get into some bad habit when developing some other projects recently...
therefore push to "master" directly. Anyway, let me know if you spot out some wrong things and I can change that.
28404a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more thing: seems like we still use the default VERSION, i.e. using git describe:
authservice/Makefile
Line 7 in 28404a8
make image push
with inlined VERSION, similar to:authservice/.github/workflows/release.yaml
Line 78 in 28404a8
$GITHUB_ENV
(just in case you need example:authservice/.github/workflows/release.yaml
Line 69 in 28404a8
Thanks!