-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-8296: Add a mTLS configuration doc #449
Conversation
Hi @yxun. Thanks for your PR. I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Yuanlin Xu <[email protected]>
Hey @yxun I added some comments, also I think we should reference this documentation in the main doc to be able to get views there |
I just saw this PR in midstream repo: openshift-service-mesh#159. Make sense to have the doc here also? |
Hello @fjglira , Which target repo should I create this PR to ? the I am not familiar with the automation between those two. I assume I only need to target one and then some automation will apply the doc change to the other one , right ? |
Hey, we have a sync job that takes all the changes from the |
Signed-off-by: Yuanlin Xu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one small change. Also I think you should reference this document in the main document, take this example from gateway
mode: STRICT | ||
EOF | ||
``` | ||
a. Replace <namespace> with the namespace where the service is located. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only small change here: you can remove the two time that is mentioned this and replace it at the end with: Note: replace <namespace> with the name of the namespace where the service is located
/ok-to-test |
Hey @yxun, as this isn't really related to sail-operator, maybe this should go into the |
right, it's more about istio configuration not about operator configuration. i will close this PR and open an OSM org repo PR today. |
What type of PR is this?
What this PR does / why we need it:
This PR is part of OSSM-8296 Istio Security User Doc topics. It adds a new common doc file about configuring mTLS and concepts using OpenShift Service Mesh.
It also improves User doc explanations according to the existing OpenShift Service Mesh 2.x Security mTLS topic:
ref: https://docs.openshift.com/container-platform/4.17/service_mesh/v2x/ossm-security.html