-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ambient User Guide - L7 Waypoint Proxy Layer Sub Guide #13954
base: master
Are you sure you want to change the base?
Conversation
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @fykaa. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review with some suggestions. Over all it looks like a good start. Thanks!
9d858f9
to
99750d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for so many suggestions.
To resolve the missing link in lint, try rebasing your branch. It's a little behind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is port 5000
coming from in the diagram? Maybe we can reuse some of the diagrams in the previous Istio blogs:
|
||
### Basic application deployment without ambient | ||
|
||
This section is Under Construction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would a be a great thing to show- you can deploy the example apps, then install Istio in ambient mode without having to restart the applications. You can probably use the sleep/notsleep example apps from Lin's getting started guide: https://istio.io/latest/blog/2022/get-started-ambient/#deploy-your-applications.
If you wanted this section to show how you can have sidecars injected in an ambient-labeled namespace:
kubectl label namespace default istio.io/dataplane-mode=ambient --overwrite=true
kubectl apply -f sleep/sleep.yaml -n default
# notsleep is in sidecar mode
kubectl apply -f <(istioctl kube-inject -f sleep/notsleep.yaml) -n default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be great! I'll try doing it this way!
Also, I was trying to figure out a way through which a user can know if he/she has not deployed a waypoint. Are there any logs or similar things for User to look at?
Co-authored-by: Daniel Hawton <[email protected]>
Co-authored-by: Daniel Hawton <[email protected]>
Co-authored-by: Nina Polshakova <[email protected]>
Co-authored-by: Nina Polshakova <[email protected]>
Co-authored-by: Nina Polshakova <[email protected]>
Hi @fykaa can you pls let us know if you are still working on this? I saw Nina proposed a few small wording changes and I've committed them. If you aren't, we are happy to pick it up. |
Co-authored-by: Nina Polshakova <[email protected]>
Reviewers - may want to hold off reviews on this as @srampal and I discussed offline a while back, major rework will be required imho. |
Co-authored-by: Daniel Hawton <[email protected]>
I would love to invest time on this, might need some directions though. |
Shall we get this ready to merge so we have something and we can then iterate on that? |
ummm wat |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This pull request addresses the issue of providing a usage guide for ambient mesh. It includes a sub-guide for the user guide on the L7 waypoint proxy. Please review and provide suggestions.
Reference:
And to help us figure out who should review this PR