-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Blog Year Buttons to Grid Layout #16022
Move Blog Year Buttons to Grid Layout #16022
Conversation
thanks for taking this on! I'm a bit worried about the article so far below the fold on mobile, given there are so many buttons. Might it be better to think of some kind of drop-down for that situation |
@craigbox - Yea... I didn't love that. A dropdown is one idea. I could also work to make the buttons a bit smaller on mobile, something like this: ![]() |
That's better, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit 2: I've found a solution that I'm happy with. Seems to work well on both https://deploy-preview-16022--preliminary-istio.netlify.app/latest/blog/ and https://deploy-preview-16022--preliminary-istio.netlify.app/latest/news/ |
Yep, good call on the margin. I've fixed that and the buttons being unequal sizes in 8e191f1.
Here is what the Blog page will look like when we get to next year and add a I think these all look pretty decent. |
In response to a cherrypick label: new pull request created: #16026 |
* Move Blog Year Buttons to Grid Layout * Resolve lint complaints * Move to 2 Columns on Mobile & Re-center Btns * Remove Fixed Btn Height & Lint Fixes * Sass Linter Fix * Return to Flexbox & Allow Wrap * Fix Margin & Make Btns Same Size
Description
Fixes: #16012
This PR:
@media
query to adjust button sizing.Reviewers