-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dart Language Spec Update, Pubification #2
Open
ess
wants to merge
12
commits into
it-agile:master
Choose a base branch
from
ess:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dart VM version: 0.2.6.0_15369_chrome-bot (Mon Nov 26 22:39:13 2012) Various language changes: * interface -> abstract class (BlockSwitcher, Matcher, Reporter) * Block is now an abstract class * new library definition: library Dahlia * new library part definitions: part of Dahlia * RegExp(blah, true) => RegExp(blah, multiLine: true) * @"blah" => r"blah" * All variations of switchTo are now declard as Block rather than void. I wouldn't think this would be necessary either, but that's what worked. * catch(type e) => catch(e) * removed parentheses from all getter names * methods without bodies can no longer be declared abstract. I believe this is because the abstraction is implicit, but I honestly haven't read up enough on that topic.
Dart VM version: 0.2.6.0_15369_chrome-bot (Mon Nov 26 22:39:13 2012) Various language changes: * interface -> abstract class (BlockSwitcher, Matcher, Reporter) * Block is now an abstract class * new library definition: library DahliaTestSuite * new library part definitions: part of DahliaTestSuite * backported the /switchTo/ changes from the library to the tests Gardening: * general matchers -> equal matcher -> "it should succeed for equal objects" the API for Duration changed, so I updated the calls to the new API. throw matcher -> "with an exception checker" -> "should succeed for an instance of a subtype of the type checked" IllegalArgumentException has changed to ArgumentError. ArgumentError doesn't inherit from or implement Exception, but is instead a subclass of Error. Changed these to FormatException instead. "with an exception checker and an exception type" "should succeed for an instance of a subtype of the type checked" Ditto.
The convention with pub packages is "don't import the private API," which basically translates to "use stuff in src at your own risk."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the library and tests to work with the current Dart SDK -
Dart VM version: 0.2.6.0_15369_chrome-bot (Mon Nov 26 22:39:13 2012)
Additionally, added a pubspec and moved things around so the library conforms to pub standard.