Feature/tag image action #47
Conversation
| description: "Image registry to push image to" | ||
| required: true | ||
| default: ghcr.io | ||
| registry-username: |
There was a problem hiding this comment.
Could we provide the value of github.actor as a default here? Or isnt this possible?
| registry-username: | ||
| description: "Username to authenticate against image registry" | ||
| required: true | ||
| registry-password: |
There was a problem hiding this comment.
Could we provide the value of secrets.GITHUB_TOKEN as a default here?
There was a problem hiding this comment.
actually secrets need to provided seperatally. there is an extra section
| required: true | ||
| new-tag: | ||
| description: 'New tag' | ||
| required: true |
There was a problem hiding this comment.
Could we provide "latest" as a default value here?
There was a problem hiding this comment.
In my opinion that is a too specific behavior for a action so i explicitly didn't set it.
workflow-templates/tag-image.yaml
Outdated
There was a problem hiding this comment.
Wouldn't it be better to add another layer of abstraction by providing a reusable workflow with a workflow_call trigger and then simplify the actual workflow template even more by just triggering the reusable workflow? See the other workflows for reference.
There was a problem hiding this comment.
Nearly every call from the templates is direct to the actions.
Also i see no real advantage in that, when correctly versioning this repository, while introducing additional complexity.
|
i don't understand why you need this. you already create a release Version with a release. 1.0, 1.1 then you dont need to tag |
|
@it-at-m/sps whtat's your opinion |
For me it would be ok to not add it to .github. I just created this for myself in refarch and thought it could be useful for others. |
|
Actually I had it here https://github.com/it-at-m/sps-backend/blob/test-neu/.github/workflows/tag-image.yaml I think if there is a error you need to do a new release. The image is immutable. For example there was an error in the gitlab runner 15.5.0. So I needed to install version 15.5.2 with the bugfix. The image 15.5.0 is always immutable |
Actually it was your suggestion to delete broken images? |
That's true. But the image tag isn't. I think it's ok to just re-tag "latest" (or any other tag) to another image if necessary. But: I'm not sure if we should provide it within the templates. It may be misunderstanding. May be better to document how re-tag could be done? |
Description
Add action for tagging a existing image.
Example run: https://github.com/it-at-m/refarch/actions/runs/11554187044