Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refac/docs configurable build cmd and node version #83

Merged
merged 12 commits into from
Dec 13, 2024

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Dec 9, 2024

Description

Make node version and build command configurable.
Fix dist path.

@simonhir simonhir requested a review from a team as a code owner December 9, 2024 11:52
@simonhir simonhir changed the title Refac/docs configurable build cmd Refac/docs configurable build cmd and node version Dec 9, 2024
@hupling
Copy link
Collaborator

hupling commented Dec 9, 2024

also das ganze Template mit den Pages kann gelöscht werden .

der @devtobi wollte das irgendwie in seine Paralelisierungsvorschläge einbauen.

#41

das ganze template ist jetzt wieder inkompatibel zur refarch geworden

@simonhir simonhir marked this pull request as draft December 11, 2024 08:28
@simonhir simonhir marked this pull request as ready for review December 11, 2024 10:21
@hupling
Copy link
Collaborator

hupling commented Dec 13, 2024

jetzt haben die noch markdownlint eingebaut. wie sollen wir das dann noch einbauen?

auch wieder mit einem input? if linting?

Copy link
Collaborator

@hupling hupling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hupling hupling merged commit ae85c28 into main Dec 13, 2024
1 check passed
@hupling hupling deleted the refac/docs-configurable-build-cmd branch December 13, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants