-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ZMS-3253 ZMS-3466 ZMS-3415 ZMS-1891): Replicate frontend validation in the backend for the availability opening hours to improve data integrity and frontend validation messaging #799
Closed
ThomasAFink
wants to merge
103
commits into
next
from
bugfix-zms-3253-3466-3415-1891-validation-opening-hours-of-the-same-appointment-type-must-not-overlap
+1,697
−397
Closed
Changes from 100 commits
Commits
Show all changes
103 commits
Select commit
Hold shift + click to select a range
310f536
fix(ZMS-3253): validate and block adding conflicting openingtimes
bbd32b1
fix(ZMS-3253): add backend validation for opening hours and improve f…
5543f36
fix(ZMS-3253): fix zmsentities unit test
03bc86e
fix(ZMS-3253): fix zmsdb unit test
ffcdb0a
fix(ZMS-3253): add logging to zmsapi tests
47565c8
fix(ZMS-3253): fix one zmsapi unit test
3f8030e
fix(ZMS-3253): try fix one zmsapi unit test
f5e08ed
fix(ZMS-3253): try fix one zmsapi unit test
e4b36ea
fix(ZMS-3253): try fix some unit tests
e5f123c
fix(ZMS-3253): try fix some unit tests
9528271
fix(ZMS-3253): try fix some unit tests
770e847
fix(ZMS-3253): try fix some unit tests
4a79605
fix(ZMS-3253): try fix some unit tests
cdd0d8c
fix(ZMS-3253): try fix some unit tests
8a1aa79
fix(ZMS-3253): try fix some unit tests
09c10fb
fix(ZMS-3253): try fix some unit tests
afd6d5d
fix(ZMS-3253): try fix some unit tests
ce5d795
fix(ZMS-3253): try fix some unit tests
07f74c8
Revert "fix(ZMS-3253): try fix some unit tests"
da65ff3
fix(ZMS-3253): try fix some unit tests
93b2820
fix(ZMS-3253): try fix some unit tests
e0d41c4
fix(ZMS-3253): try fix some unit tests
bde21f3
fix(ZMS-3253): try fix some unit tests
0cd0ad1
fix(ZMS-3253): try fix some unit tests
29b7cff
fix(ZMS-3253): try fix some unit tests
9e11157
fix(ZMS-3253): try fix some unit tests
c2df444
fix(ZMS-3253): try fix some unit tests
5faea71
fix(ZMS-3253): try fix some unit tests
4cd3618
fix(ZMS-3253): try fix some unit tests
4840338
fix(ZMS-3253): try fix some unit tests
c8262a0
fix(ZMS-3253): backend validation work in AvailabilityAdd
8281b0a
fix(ZMS-3253): correct backend validation for timeoverlaps
390aba7
fix(ZMS-3253): fix a validation
78013ea
fix(ZMS-3253): try fixing a test
8a07621
fix(ZMS-3253): try fixing a test
7892fe0
fix(ZMS-3253): try fixing a test
9522585
fix(ZMS-3253): try fixing a test
d65ccb8
fix(ZMS-3253): try fixing availability not found test
3fa84a1
fix(ZMS-3253): try fixing availability mockdata for testRendering
317d127
fix(ZMS-3253): try fixing availability mockdata for testRendering
c02e4e3
fix(ZMS-3253): try fixing availability mockdata for testRendering
c75e3c4
fix(ZMS-3253): try fixing availability mockdata for testRendering
2b39546
fix(ZMS-3253): try fixing availability mockdata for testRendering
acb62ac
fix(ZMS-3253): try fix missing scope testRendering
a16b2e4
fix(ZMS-3253): fix zmsadmin availabilities conflict test
1bd40cb
fix(ZMS-3253): show availability opening hour conflicts in the future…
4025319
fix(ZMS-3253): remove error_logs
95dcef0
fix(ZMS-3253): refactor function logic getDateTimeRangeFromList to on…
39ef3a6
Merge remote-tracking branch 'origin/next' into bugfix-zms-3253-valid…
3eb8912
fix(ZMS-3253): renable twig cache
46c0af9
fix(ZMS-3253): renable twig cache
fdd0c72
fix(ZMS-3253): fix unit test
ThomasAFink f319de3
fix(ZMS-3253): fix unit test
ThomasAFink b8fd6b6
fix(ZMS-3253): fix unit test
ThomasAFink a2691c1
fix(ZMS-3253): fix unit test
ThomasAFink fc26e13
fix(ZMS-3253): fix unit test
ThomasAFink bffc9fa
fix(ZMS-3253): fix unit test
ThomasAFink 5784eb4
fix(ZMS-3253): try fix unit test
ThomasAFink 51e25ca
fix(ZMS-3253): add unit tests for testing overlapping availability op…
ThomasAFink 4f2a125
fix(ZMS-3253): add unit tests for testing overlapping availability op…
ThomasAFink e8cae55
fix(ZMS-3253): remove space
ThomasAFink e0f4fa6
fix(ZMS-3253): remove space
ThomasAFink d17ffa2
fix(ZMS-3253): add unit tests for testing overlapping availability op…
ThomasAFink 8a41469
fix(ZMS-3253): add unit tests for testing validation availability ope…
ThomasAFink e230b26
fix(ZMS-3253): add unit tests for testing overlapping availability op…
ThomasAFink 5aadb7b
fix(ZMS-3253): add unit tests for testing validation availability ope…
ThomasAFink 246b4d1
fix(ZMS-3253): add unit tests for testing overlapping availability op…
ThomasAFink 17dcb07
fix(ZMS-3253): add unit tests for testing overlapping availability op…
ThomasAFink e984774
fix(ZMS-3253): add unit tests for testing overlapping availability op…
ThomasAFink d5135e2
fix(ZMS-3253): add unit tests for testing overlapping availability op…
ThomasAFink ca99ef2
fix(ZMS-3253): add unit tests for testing validation availability ope…
ThomasAFink d5c6051
fix(ZMS-3253): add unit tests for testing validation availability ope…
ThomasAFink 5527c58
fix(ZMS-3253): refactor object creation
ThomasAFink ad89835
fix(ZMS-3253): refactor exception messages
ThomasAFink 2a7d978
fix(ZMS-3253): clean up commented code
ThomasAFink ea55b27
fix(ZMS-3253): fix grammar
ThomasAFink 932fe5f
fix(ZMS-3253): comment error_log
ThomasAFink 5aa9d6b
fix(ZMS-3253): Improve frontend validation for opening hours availabi…
ThomasAFink fb7efb7
cleanup(ZMS-3415): remove invalid text instruction for graph view ope…
ThomasAFink 1fd8f65
fix(ZMS-1891): Add missing frontend validation for timepicker
f8f536f
Merge branch 'next' into bugfix-zms-3253-validation-opening-hours-of-…
e4981ff
fix(ZMS-1891): Improve frontend validation for time formats
7916a70
fix(ZMS-3253): fix frontend exclusion availability validation
ThomasAFink 462be60
fix(ZMS-3253): fix backend exclusion availability validation
ThomasAFink 46db273
fix(ZMS-3253): allow exclusion availability on current date
ThomasAFink 490ddce
fix(ZMS-3253): improve validation and cleanup code
ThomasAFink 2ce2363
fix(ZMS-3253): move js spinner
ThomasAFink 735c579
Merge remote-tracking branch 'origin/next' into bugfix-zms-3253-valid…
ThomasAFink 97cee9c
clean(ZMS-3253): remove console logs
ThomasAFink a11f7b8
Merge branch 'next' into bugfix-zms-3253-validation-opening-hours-of-…
b620a54
fix(ZMS-3466): fix bookable day range validation
e3375c1
fix(ZMS-3466): fix error accumulation
e646a4c
fix(ZMS-3466): improve exception handling
8b7a1f6
fix(ZMS-3466): improve validation prevent divide by zero
2a3cbb7
fix(ZMS-3466): improve validation prevent divide by zero
4cbe423
fix(ZMS-3466): improve validation prevent divide by zero
0053e60
Merge branch 'next' into bugfix-zms-3253-3466-3415-1891-validation-op…
ThomasAFink cab1b1d
fix(ZMS-3466): Fix to from default values in opening hours availability
ThomasAFink ab51699
fix(ZMS): error message
227e741
Merge branch 'next' into bugfix-zms-3253-3466-3415-1891-validation-op…
694194b
fix(ZMS-3466): fix open from and open to placeholders in form
d53b28e
Merge branch 'next' into bugfix-zms-3253-3466-3415-1891-validation-op…
088356f
fix(ZMS-3466): improve default hours
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security: Replace dangerouslySetInnerHTML with safe alternative.
Using dangerouslySetInnerHTML with unsanitized content poses an XSS risk. Consider using a safe alternative.
📝 Committable suggestion
🧰 Tools
🪛 Biome (1.9.4)
[error] 33-33: Avoid passing content using the dangerouslySetInnerHTML prop.
Setting content using code can expose users to cross-site scripting (XSS) attacks
(lint/security/noDangerouslySetInnerHtml)