Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 introduce sass #306 #307

Draft
wants to merge 10 commits into
base: beta
Choose a base branch
from
Draft

Conversation

langehm
Copy link
Contributor

@langehm langehm commented Nov 4, 2024

Description

  • added some css-classes

Reference

Issues #306

@langehm langehm linked an issue Nov 4, 2024 that may be closed by this pull request
@langehm langehm self-assigned this Nov 4, 2024
@langehm
Copy link
Contributor Author

langehm commented Nov 4, 2024

Currently only as an example

@langehm langehm changed the title 💄 added some classes as an example #306 💄 introduce sass #306 Nov 25, 2024
@langehm
Copy link
Contributor Author

langehm commented Nov 25, 2024

@FabianWilms I think we need to discuss the file structure here. Formating of the fontface-css files should not be done.
BUT we should include all the manually added css-files into prettifier and eslint!

@FabianWilms
Copy link
Member

Formating of the fontface-css files should not be done.

I think this goes for all files coming from MDE directly - so everything in the temp-directory?

@FabianWilms
Copy link
Member

BUT we should include all the manually added css-files into prettifier and eslint!

Definitely

@langehm
Copy link
Contributor Author

langehm commented Dec 8, 2024

Formating of the fontface-css files should not be done.

I think this goes for all files coming from MDE directly - so everything in the temp-directory?

We currently have manual files in the temp directory :D that is the problem I want to adress

@FabianWilms
Copy link
Member

Formating of the fontface-css files should not be done.

I think this goes for all files coming from MDE directly - so everything in the temp-directory?

We currently have manual files in the temp directory :D that is the problem I want to adress

Which idiot thought this was a good idea?

Yeah we should definitely move them one folder up. This would sadly require a breaking change release.

@langehm
Copy link
Contributor Author

langehm commented Dec 10, 2024

Formating of the fontface-css files should not be done.

I think this goes for all files coming from MDE directly - so everything in the temp-directory?

We currently have manual files in the temp directory :D that is the problem I want to adress

Which idiot thought this was a good idea?

Yeah we should definitely move them one folder up. This would sadly require a breaking change release.

It is what it is ... no seperate folder just one up?

I don't know who is meant by this but I certainly don't think he/she is an idiot ;)

@FabianWilms
Copy link
Member

Formating of the fontface-css files should not be done.

I think this goes for all files coming from MDE directly - so everything in the temp-directory?

We currently have manual files in the temp directory :D that is the problem I want to adress

Which idiot thought this was a good idea?
Yeah we should definitely move them one folder up. This would sadly require a breaking change release.

It is what it is ... no seperate folder just one up?

I don't know who is meant by this but I certainly don't think he/she is an idiot ;)

I'm open to suggestions and don't really have a preferred opinion. A new folder could be more organized but might never contain more files.

You decide!

…irectory

This change requires users of the lib to fix their imports. Please refer to the 'Getting Started' section for the new way to import the required assets.
@FabianWilms
Copy link
Member

@langehm I reworked the way we import MDE assets and moved our own assets away from the temporary directory with 9baf710 (a breaking change).

From here on you can continue to implement the SASS-enhancement.

If you're really fancy you can combine all our "custom" css files into one in our build, so we're no longer required to import our two custom css-files seperately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

centralized general css classes
2 participants