💄 354 removed watcher from filedropzone and reformated

[langehm]

Description

• removed watcher and prop for reseting the warnings (see issue for example)
• formated code
• formated comments to multiline
• used 3.3+ vue and typescript way of Emits
• reformated if conditions without brackets

Reference

Issues #354

[langehm]

I removed the _ from the functions - saw no purpose in the lowdash and we are not differentiating between different types of functions.
We don#t use if statements without brackets moreover some empty return statements could be removed by just using 1 (one) else.

[langehm]

And i moved the default story to the top - it should be the first story to be seen.

[FabianWilms]

As this would be a breaking change for users of this component I would like to get @markostreich to review this, too.

To me it looks good. I don't know if I like the automatic approach of the watcher or the more functional approach more.

Code wise it LGTM

[langehm]

As this would be a breaking change for users of this component I would like to get @markostreich to review this, too.

To me it looks good. I don't know if I like the automatic approach of the watcher or the more functional approach more.

Code wise it LGTM

Yes would be good if @markostreich looks over this one!
I dislike watcher as they can stack very easily. More over the prop for reseting is not a call, it was a boolean which normally is toggled but here need to be set dynamically to true!

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[markostreich]

I tested the new approach successfully. We can adopt the change. As mentioned in my two comments, the presentation in the Storybook should now also be adjusted to include a demonstration of the clearance of warnings so that interested users can see how it works.

[markostreich]

I am unfortunately no longer part of this project.

[langehm]

I am unfortunately no longer part of this project.

huh o.O

[github-actions]

🎉 This PR is included in version 2.1.0-beta.6 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀