Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ s3 replace star imports #158

Merged
merged 2 commits into from
Sep 18, 2024
Merged

♻️ s3 replace star imports #158

merged 2 commits into from
Sep 18, 2024

Conversation

simonhir
Copy link
Member

Description

Replace star imports for s3-integration

@simonhir simonhir self-assigned this Sep 17, 2024
@simonhir simonhir marked this pull request as ready for review September 17, 2024 05:31
@simonhir simonhir requested a review from a team as a code owner September 17, 2024 05:31
@github-actions github-actions bot added Component: Integrations Issues regarding the Integrations Type: Maintenance The issue contains maintenance work. labels Sep 17, 2024
devtobi
devtobi approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit 22ffdb7 into main Sep 18, 2024
9 checks passed
@simonhir simonhir deleted the refactor/s3-star-imports branch September 18, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devtobi devtobi devtobi approved these changes

Assignees

@simonhir simonhir

Labels
Component: Integrations Issues regarding the Integrations Type: Maintenance The issue contains maintenance work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhir @devtobi