Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use jdk21 #16

Merged
merged 2 commits into from
Jul 26, 2024
Merged

use jdk21 #16

merged 2 commits into from
Jul 26, 2024

Conversation

simonhir
Copy link
Member

Description

Use jdk 21 instead of 17

@simonhir simonhir self-assigned this Jul 18, 2024
@simonhir simonhir requested a review from devtobi July 22, 2024 05:09
devtobi
devtobi requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small pom change needed, I guess you checked the rest of the dependencies (especially Spring Boot) for JDK 21 compatibility, right?

refarch-gateway/pom.xml Outdated Show resolved Hide resolved
@simonhir @devtobi
Update refarch-gateway/pom.xml
19daf8e 
Co-authored-by: Tobias Stadler <[email protected]>
@simonhir
Copy link
Member Author

I guess you checked the rest of the dependencies (especially Spring Boot) for JDK 21 compatibility, right?

Didn't check every single dependency but for functionality and Spring-Boot and Spring-Cloud support each at least jdk 21.

devtobi
devtobi approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit 9b031e1 into main Jul 26, 2024
5 checks passed
@simonhir simonhir deleted the feature/jdk21 branch July 26, 2024 04:50
@simonhir simonhir mentioned this pull request Jul 29, 2024
Merged
@devtobi devtobi added Component: API-Gateway Issues regarding the API Gateway Type: Maintenance The issue contains maintenance work. labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devtobi devtobi devtobi approved these changes

Assignees

@simonhir simonhir

Labels
Component: API-Gateway Issues regarding the API Gateway Type: Maintenance The issue contains maintenance work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhir @devtobi