Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency net.logstash.logback:logstash-logback-encoder to v8 #33

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 27, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
net.logstash.logback:logstash-logback-encoder 7.4 -> 8.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested review from a team as code owners July 27, 2024 22:13
@devtobi
Copy link
Member

devtobi commented Jul 29, 2024

Why was this bump necessary? Is it for Java 21 compatibility? I checked release notes at https://github.com/logfellow/logstash-logback-encoder/releases/tag/logstash-logback-encoder-8.0.
Do we fulfill the new requirements for supported dependencies mentioned in the Changelog?

logback-core/classic 1.5.x.
logback-access 2.0.x
jackson-* 2.17.x

Are we affected of this?

@simonhir
Copy link
Member

simonhir commented Jul 30, 2024

Why was this bump necessary?

Not really sure what you mean with that. This is just a version bump created by renovate as a new version of the used package was released.

Do we fulfill the new requirements

We don't use logback-access and the other requirements are fulfilled.

Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit 98010ff into main Jul 31, 2024
5 checks passed
@simonhir simonhir deleted the renovate/major-logstash.encoder.version branch July 31, 2024 04:49
@simonhir simonhir added the Type: Dependency The issue is a dependency update. label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Dependency The issue is a dependency update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants