Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/cleanup gateway #76

Merged
merged 7 commits into from
Aug 16, 2024
Merged

Refactor/cleanup gateway #76

merged 7 commits into from
Aug 16, 2024

Conversation

simonhir
Copy link
Member

Description

Cleanup gateway:

  • rm unneeded no security properties file
  • cleanup properties to match integrations
  • add local properties

@simonhir simonhir self-assigned this Aug 16, 2024
@simonhir simonhir requested a review from a team as a code owner August 16, 2024 08:29
devtobi
devtobi previously approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir enabled auto-merge (squash) August 16, 2024 08:48
@simonhir simonhir disabled auto-merge August 16, 2024 08:48
devtobi
devtobi approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit 6b25b39 into main Aug 16, 2024
6 checks passed
@simonhir simonhir deleted the refactor/cleanup-gateway branch August 16, 2024 09:19
@devtobi devtobi added Component: API-Gateway Issues regarding the API Gateway Component: Integrations Issues regarding the Integrations Type: Maintenance The issue contains maintenance work. labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devtobi devtobi devtobi approved these changes

Assignees

@simonhir simonhir

Labels
Component: API-Gateway Issues regarding the API Gateway Component: Integrations Issues regarding the Integrations Type: Maintenance The issue contains maintenance work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhir @devtobi