Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanceezldap #8

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Enhanceezldap #8

merged 5 commits into from
Mar 22, 2024

Conversation

FabianWilms
Copy link
Member

Description

Enhance existing ezldap classes.

@FabianWilms FabianWilms requested a review from sfi2022 March 21, 2024 11:09
sfi2022
sfi2022 reviewed Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@sfi2022 sfi2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Testcase is running for me.
  • We do not contribute to ezldap.
  • We just have another dependency with inheritance that we have to take into account.
  • If the architect is happy with that, we can do. Even if i don't see much benefits.

@FabianWilms FabianWilms merged commit 3b2ac41 into dev Mar 22, 2024
1 check passed
@sfi2022 sfi2022 deleted the enhanceezldap branch July 22, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfi2022 sfi2022 sfi2022 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabianWilms @sfi2022