Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/301 upgrade angular 17 #314

Merged
merged 12 commits into from
Feb 5, 2024
Merged

Fix/301 upgrade angular 17 #314

merged 12 commits into from
Feb 5, 2024

Conversation

AntoninoBonanno
Copy link
Collaborator

@AntoninoBonanno AntoninoBonanno commented Feb 3, 2024

Descrizione

  • Aggiornata la libreria e la documentazione ad Angular 17 (Upgrade Angular 17 #301)
  • Ottimizzati i componenti della libreria utilizzando il control-flow introdotto da Angular 17
  • Aggiunta la funzione di supporto provideDesignAngularKit per le applicazioni con configurazione standalone
  • Aggiunta la possibilità di caricare automaticamente i font di bootstrap-italia (configurabile)
  • Aggiornato README.md

BREAKING CHANGES:

  • E' cambiata la configurazione iniziale della libreria, in particolare l'attributo iconHref è stato sostituito con il campo assetBasePath

    • per retrocompatibilità, cambiare iconHref: '<my-custom-path>/dist/svg/sprites.svg' con assetBasePath: '<my-custom-path>'
  • Se si utilizza un applicazione con i moduli (non standalone) adesso è necessario importare la libreria con il metodo forRoot: DesignAngularKitModule.forRoot() (Readme.md aggiornato)

  • Il modulo ItComponentsModule è stato inglobato nel modulo DesignAngularKitModule

    • per retrocompatibilità, se non si vuole importare tutti i componenti nel AppModule vedere la sezione Applicazione ibrida del README.md

Checklist

Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-angular-kit ✅ Ready (Inspect) Visit Preview Feb 4, 2024 5:28pm

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (daea2e3) 46.87% compared to head (de97f3e) 45.65%.
Report is 3 commits behind head on main.

Files Patch % Lines
.../core/tab/tab-container/tab-container.component.ts 31.25% 10 Missing and 1 partial ⚠️
...components/core/pagination/pagination.component.ts 14.28% 6 Missing ⚠️
...orm/upload-file-list/upload-file-list.component.ts 0.00% 6 Missing ⚠️
...omponents/utils/error-page/error-page.component.ts 16.66% 5 Missing ⚠️
...b/components/navigation/header/header.component.ts 0.00% 4 Missing ⚠️
...nents/core/carousel/carousel/carousel.component.ts 71.42% 2 Missing ⚠️
...steppers-container/steppers-container.component.ts 71.42% 2 Missing ⚠️
...ion/breadcrumbs/breadcrumb/breadcrumb.component.ts 71.42% 2 Missing ⚠️
...s/language-switcher/language-switcher.component.ts 50.00% 2 Missing ⚠️
...ts/form/password-input/password-input.component.ts 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   46.87%   45.65%   -1.23%     
==========================================
  Files          81       70      -11     
  Lines        1169     1128      -41     
  Branches      242      235       -7     
==========================================
- Hits          548      515      -33     
+ Misses        597      588       -9     
- Partials       24       25       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntoninoBonanno AntoninoBonanno marked this pull request as draft February 4, 2024 00:52
@astagi astagi marked this pull request as ready for review February 4, 2024 09:48
@astagi astagi linked an issue Feb 5, 2024 that may be closed by this pull request
@astagi astagi merged commit 072df92 into main Feb 5, 2024
4 of 6 checks passed
Copy link
Contributor

github-actions bot commented Feb 8, 2024

🎉 This PR is included in version 1.0.0-prerelease.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@astagi astagi deleted the fix/301-upgrade-angular-17 branch February 12, 2024 14:42
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Angular 17
2 participants