-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/timeline #347
Feat/timeline #347
Conversation
Aggiunta proprietà link relativa a slimTitle in ItHeaderComponent (visualizzazione desktop)
Fix proprietà che possono risultare undefined e vincolato quelle obbligatorie
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@stefanozanelliunitn ho riportato il tuo lavoro qua almeno possiamo cominciare a revisionarlo e fare i test del caso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefanozanelliunitn grazie per questo componente! Ho lasciato alcuni commenti in questa review, inoltre occorre risolvere i problemi di linting
@@ -60,7 +60,8 @@ | |||
"back": "Indietro", | |||
"forward": "Avanti", | |||
"rate-star": "Valuta {{current}} stelle su {{total}}", | |||
"rating-star": "Valutazione {{current}} stelle su {{total}}" | |||
"rating-star": "Valutazione {{current}} stelle su {{total}}", | |||
"today": "Oggi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefanozanelliunitn metterei la label "today" all'interno di "timeline" come scope
|
||
import { TimelineExamplesComponent } from './timeline-examples.component'; | ||
|
||
describe('AlertExamplesComponent', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qui è rimasto "Alert" invece che "Timeline"
changeDetection: ChangeDetectionStrategy.OnPush, | ||
imports: [ItIconComponent, TranslateModule, ItTimelineItemComponent], | ||
}) | ||
export class ItTimelineContainerComponent extends ItAbstractComponent { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lo chiamerei semplicemente ItTimelineComponent
che ne dici @AntoninoBonanno ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mhh forse si
Fix unit test e riferimenti a documentazione autogenerata; spostata etichetta in scope timeline
Corretto mancato riferimento a componenti standalone
Ho corretto alcune delle cose non funzionanti. Sul branch Timeline dovrebbe esserci tutto. |
Descrizione
Fixes #345
Checklist