Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Angular 18 and Bootstrap Italia #367

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Conversation

AntoninoBonanno
Copy link
Collaborator

Descrizione

  • Aggiornato Angular alla v18. Angular 18 support #361
  • Aggiornato Bootstrap Italia alla v2.8.8
  • Aggiornate altre dipendenze
  • Risolte vulnerabilità causate dalle dipendenze

Checklist

Copy link

vercel bot commented Jul 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-angular-kit ✅ Ready (Inspect) Visit Preview Jul 17, 2024 9:26am

dependabot bot and others added 5 commits July 17, 2024 11:25
Removes [pdfjs-dist](https://github.com/mozilla/pdfjs-dist). It's no longer used after updating ancestor dependency [@compodoc/compodoc](https://github.com/compodoc/compodoc). These dependencies need to be updated together.


Removes `pdfjs-dist`

Updates `@compodoc/compodoc` from 1.1.23 to 1.1.25
- [Release notes](https://github.com/compodoc/compodoc/releases)
- [Changelog](https://github.com/compodoc/compodoc/blob/develop/CHANGELOG.md)
- [Commits](compodoc/compodoc@1.1.23...1.1.25)

---
updated-dependencies:
- dependency-name: pdfjs-dist
  dependency-type: indirect
- dependency-name: "@compodoc/compodoc"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ws](https://github.com/websockets/ws), [engine.io](https://github.com/socketio/engine.io) and [socket.io-adapter](https://github.com/socketio/socket.io-adapter). These dependencies needed to be updated together.

Updates `ws` from 8.16.0 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.16.0...8.17.1)

Updates `engine.io` from 6.5.2 to 6.5.5
- [Release notes](https://github.com/socketio/engine.io/releases)
- [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md)
- [Commits](socketio/engine.io@6.5.2...6.5.5)

Updates `socket.io-adapter` from 2.5.2 to 2.5.5
- [Release notes](https://github.com/socketio/socket.io-adapter/releases)
- [Changelog](https://github.com/socketio/socket.io-adapter/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io-adapter@2.5.2...2.5.5)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: engine.io
  dependency-type: indirect
- dependency-name: socket.io-adapter
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
BREAKING CHANGE: support Angular 18
Closes: #361
Copy link
Member

@astagi astagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntoninoBonanno grazie per questa PR, due considerazioni

  • mi porta Vercel in 404
  • alcuni commit hanno un body troppo lungo, se dovesse interferire con l'auto generazione del changelog modifichiamolo

@AntoninoBonanno
Copy link
Collaborator Author

@AntoninoBonanno grazie per questa PR, due considerazioni

  • mi porta Vercel in 404
  • alcuni commit hanno un body troppo lungo, se dovesse interferire con l'auto generazione del changelog modifichiamolo

Per Vercel si dovrà modificare il path, infatti angular 18 effettua la build su dist/design-angular-kit-bundle/browser invece che dist/design-angular-kit-bundle

Nei file dei workflow l'ho modificato, ma non vedo quello per Vercel.

I commit, a parte quelli di dependabot mi sembrano ok.
Ma se vuoi puoi fare uno squash commit con messaggio

feat: upgrade to Angular 18

BREAKING CHANGE: support Angular 18
Closes: #361

@astagi
Copy link
Member

astagi commented Jul 18, 2024

@AntoninoBonanno grazie per questa PR, due considerazioni

  • mi porta Vercel in 404
  • alcuni commit hanno un body troppo lungo, se dovesse interferire con l'auto generazione del changelog modifichiamolo

Per Vercel si dovrà modificare il path, infatti angular 18 effettua la build su dist/design-angular-kit-bundle/browser invece che dist/design-angular-kit-bundle

Nei file dei workflow l'ho modificato, ma non vedo quello per Vercel.

I commit, a parte quelli di dependabot mi sembrano ok. Ma se vuoi puoi fare uno squash commit con messaggio

feat: upgrade to Angular 18

BREAKING CHANGE: support Angular 18
Closes: #361

Chiarissimo! Grazie @AntoninoBonanno ! Va bene per lo squash del commit procedi pure ☺️🙏

@AntoninoBonanno AntoninoBonanno merged commit cc1eb35 into main Jul 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 18 support
2 participants