refactor: use fiber constant for error message

italia · Oct 10, 2022 · 48bbda8 · 48bbda8
1 parent 5592e82
commit 48bbda8
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 6 deletions.
diff --git a/internal/handlers/logs.go b/internal/handlers/logs.go
@@ -76,7 +76,11 @@ func (p *Log) GetLog(ctx *fiber.Ctx) error {
 			return common.Error(fiber.StatusNotFound, "can't get Log", "Log was not found")
 		}
 
-		return common.Error(fiber.StatusInternalServerError, "can't get Log", "internal server error")
+		return common.Error(
+			fiber.StatusInternalServerError,
+			"can't get Log",
+			fiber.ErrInternalServerError.Message,
+		)
 	}
 
 	return ctx.JSON(&log)
@@ -122,7 +126,11 @@ func (p *Log) PatchLog(ctx *fiber.Ctx) error {
 			return common.Error(fiber.StatusNotFound, "can't update Log", "Log was not found")
 		}
 
-		return common.Error(fiber.StatusInternalServerError, "can't update Log", "internal server error")
+		return common.Error(
+			fiber.StatusInternalServerError,
+			"can't update Log",
+			fiber.ErrInternalServerError.Message,
+		)
 	}
 
 	log.Message = logReq.Message

diff --git a/internal/handlers/publishers.go b/internal/handlers/publishers.go
@@ -77,7 +77,11 @@ func (p *Publisher) GetPublisher(ctx *fiber.Ctx) error {
 			return common.Error(fiber.StatusNotFound, "can't get Publisher", "Publisher was not found")
 		}
 
-		return common.Error(fiber.StatusInternalServerError, "can't get Publisher", "internal server error")
+		return common.Error(
+			fiber.StatusInternalServerError,
+			"can't get Publisher",
+			fiber.ErrInternalServerError.Message,
+		)
 	}
 
 	return ctx.JSON(&publisher)
@@ -127,7 +131,7 @@ func (p *Publisher) PostPublisher(ctx *fiber.Ctx) error {
 		default:
 			return common.Error(fiber.StatusInternalServerError,
 				"can't create Publisher",
-				"internal server error")
+				fiber.ErrInternalServerError.Message)
 		}
 	}
 

diff --git a/internal/handlers/software.go b/internal/handlers/software.go
@@ -199,7 +199,11 @@ func (p *Software) PatchSoftware(ctx *fiber.Ctx) error { //nolint:cyclop // most
 			return common.Error(fiber.StatusNotFound, "can't update Software", "Software was not found")
 		}
 
-		return common.Error(fiber.StatusInternalServerError, "can't update Software", "internal server error")
+		return common.Error(
+			fiber.StatusInternalServerError,
+			"can't update Software",
+			fiber.ErrInternalServerError.Message,
+		)
 	}
 
 	if err := ctx.BodyParser(softwareReq); err != nil {

diff --git a/internal/handlers/webhooks.go b/internal/handlers/webhooks.go
@@ -28,7 +28,11 @@ func (p *Webhook[T]) GetWebhook(ctx *fiber.Ctx) error {
 			return common.Error(fiber.StatusNotFound, "can't get Webhook", "Webhook was not found")
 		}
 
-		return common.Error(fiber.StatusInternalServerError, "can't get Webhook", "internal server error")
+		return common.Error(
+			fiber.StatusInternalServerError,
+			"can't get Webhook",
+			fiber.ErrInternalServerError.Message,
+		)
 	}
 
 	return ctx.JSON(&webhook)