fix #65 #66
fix #65 #66
Conversation
this pulls in the spid-php-lib from a temporary side-branch until italia/spid-php-lib#66 gets merged it is self-documenting on which version of spid-php-lib we're bundling (just look in composer.json) the supplied bundle.sh script can be used by the maintainer to update the bundled copy of spid-php-lib in an automated way, guaranteeing it is a 1-to-1 copy of the original for an authentication-related plugin like this one, we need to make the build reproducible and to self-document all files not written by us which land into the plugin
|
The idea is good, but we should make this automated IMHO. It would be best if the constructor checked if keys already exist, and in case they don't create them. Also, the example has not been updated with these methods. I'm working on these changes and I'll be pushing here for further review |
|
Automated certificates generation could be useful for testing. But for the WordPress plugin, once you installed and activated it, it is not configured: the information required to generate the metadata and the certificates (for example the organization name) is missing, and in a near future even the location where to look for / write the certificates would be unknown. The idea drafted here is to have then the WordPress plugin enter an "unconfigured" state (does not generate metadata and SPID button does not work) until at least the data for the certificates has been filled in, and their generation has been manually requested. |
No description provided.