VOMS v. 2.1.0 #139
Merged
VOMS v. 2.1.0 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ports VOMS to OpenSSL 1.1. More details in openssl11.md.
Porting to OpenSSL 1.1
Fix issue #60
…lifre-wsdl2h-detect * 'wsdl2h-detect' of https://github.com/olifre/voms: wsdl2h.m4: Fix detection of modern wsdl2h versions. Fixes for README.md
Based on italiangrid/pkg.base:centos6
Fix https://issues.infn.it/jira/browse/VOMS-875 (for the part about incompatible AC)
Add a class static function to allow clients to skip OpenSSL initialization. This makes sense only for versions up to 1.0.2; above that the initialization is done automatically. There is no check on this though, to minimize changes. Moreover OpenSSL (if not skipped) and AC- and Proxy-related functionality are initialized atomically. The flag that tells if OpenSSL needs to be initialized is not atomic because it is checked inside the critical section of pthread_once. Fixes: #89
Fix AC incompatibilty introduced with the migration to OpenSSL 1.1
Align develop-2.1.x with develop
The depth of some fields was not correct for the response obtained through the REST API, which is the first one tried and the only one that will survive in the future with VOMS-AA. In addition, VOMS-AA returns a numeric code for an error condition, not a string like VOMS server.
* Always process the errors, not only in case an AC has been returned * For certain errors (user doesn't exist, is suspended, is inactive) do not try the legacy endpoint, which doesn't even exist for VOMS AA * Leave some commented-out debug messages, to be possibly included in the output in debug mode (requires some work to propagate the debug flag)
Fixes build error if all targets are made.
voms-server: chown-with-dot root.voms [usr/share/voms/voms_install_db:276] chown-with-dot The named script uses a dot to separate owner and group in a call like chown user.group but that usage is deprecated. Please use a colon instead, as in: chown user:group.
Contrary to the VOMS server, VOMS-AA expects that the fqans query parameter includes also the FQANs specified with the --order command line argument of voms-proxy-init. We keep the order query parameter, which is instead expected by the VOMS server.
And avoid the use of std::next, which is C++11
…nd-clients-to-voms-aa Adapt client libraries and clients to voms aa
They were replaced by those coming from globus during the migration to OpenSSL 1.1.
…dist-is-missing-several-files Clean the distribution tarball
Return false in case the certificate is about to expire, causing the (only) caller to subsequently verify the proxy.
The mode passed to access is an int and not a string, like in fopen.
Just rely on the canonical loop over the error stack, without special treatment for an expired certificate, which is caught somewhere else in any case. Be sure that the data added to an error is a text string before printing it.
The code mentions OpenSSL functions related to error management, which has changed in OpenSSL 3, deprecating old practices.
The use of the function name in errors has been abandoned in OpenSSL 3. Profit to replace the use of sprintf with snprintf.
To be more compatible with how it was done before.
…r-openssl-300-needs-further-fixing Avoid function names when printing OpenSSL errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the version in
configure.acis erroneously set to2.1.1(see #135).