-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added backend docker configs #168
Open
tk-hamaguchi
wants to merge
2
commits into
itamae-kitchen:master
Choose a base branch
from
tk-hamaguchi:add_backend_docker_configs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added backend docker configs #168
tk-hamaguchi
wants to merge
2
commits into
itamae-kitchen:master
from
tk-hamaguchi:add_backend_docker_configs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk-hamaguchi
commented
Oct 3, 2015
- Added tty: true to execute commands with docker.
- Modified log format with docker results.
I apologize for my poor English. |
@@ -74,7 +74,7 @@ def run_command(commands, options = {}) | |||
end | |||
|
|||
if options[:error] && result.exit_status != 0 | |||
raise CommandExecutionError | |||
fail CommandExecutionError, result.stderr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer raise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I'll fix the code later.
* Modified log format with docker results.
tk-hamaguchi
force-pushed
the
add_backend_docker_configs
branch
from
October 21, 2015 14:04
a320c23
to
6591d75
Compare
@tk-hamaguchi Sorry for very late reply... Would you rebase the branch? |
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.