Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate mongo roles #117

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

steven-schattenberg-itential
Copy link
Contributor

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this file? I don't think it's used, is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using it. To build active standby you just call the normal deployer playbooks.

roles/mongodb/tasks/configure-mongodb-replicaset.yml Outdated Show resolved Hide resolved
roles/mongodb/tasks/configure-mongodb-replicaset.yml Outdated Show resolved Hide resolved
roles/mongodb/templates/mongod.conf.j2 Outdated Show resolved Hide resolved
**/*.keep
inventories
playbooks/files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should have playbooks/file in the git ignore list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this because its registering many of my download bin files as changes. Those should be ignored, right???

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a guide for creating a local .gitignore.

Comment on lines -8 to -12
- name: Determine the primary server
ansible.builtin.include_role:
name: mongodb_common
tasks_from: determine-primary-server.yml
when: mongobdb_svc_url_itential is not defined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this unnecessary because we're using the mongo_connection_string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. In the case of a replset, the mongo connection string should contain all members and the driver should figure out which one is the primary.

**/*.keep
inventories
playbooks/files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a guide for creating a local .gitignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants