Add codespell: config, workflow (to alert when new typos added) and get typos fixed #15437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
macos-13 is failing also in https://github.com/iterate-ch/cyberduck/actions/runs/7120060984 for another PR |
|
Our documentation would benefit from this build action a lot more. |
|
Generated code from swagger-codegen should be excluded from spelling checks. |
|
is it the what is it generated from since it seems to have unique to it typos ❯ git grep beeing
storegate/src/main/java/ch/cyberduck/core/storegate/io/swagger/client/api/WebDavPasswordApi.java: * Remove a WebDAV password to stop it from beeing used.
storegate/src/main/java/ch/cyberduck/core/storegate/io/swagger/client/api/WebDavPasswordApi.java: * Remove a WebDAV password to stop it from beeing used. |
The data types are generated from an API specification (that includes the typos) outside the scope of this project. |
…ut ignoring the failure due to ambigous typos
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w || :",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
force-pushed
the
enh-codespell
branch
from
5aa973d
to
3d62b60
Compare
|
ok, ignored |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my way to contribute back to projects I touch to use or told about (thus popular).
codespell: https://github.com/codespell-project/codespell to discover more
I spotted some code changes - but all looked good to be changed, but please review more.
I ignored 'unsecure' in a config setting
connection.unsecureto not cause disturbance.You can annotate lines to be ignored with e.g.
/* pragma: codespell-ignore */so you could even add suggestions right here in the diff as suggestions to expedite reversion back if needed.