-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/migration cyberduck release windows chocolatey #15479
base: master
Are you sure you want to change the base?
Features/migration cyberduck release windows chocolatey #15479
Conversation
…-release-windows set distributionManagement repos to local
…ndows-to-actions-20231210-172433 Convert cyberduck-release-windows to GitHub Actions
…-release-windows Add option for git tag
…-release-windows Fix WORKSPACE variable
…ndows-chocolatey-to-actions-20231211-122942 Convert cyberduck-release-windows-chocolatey to GitHub Actions
Added Secret API Key
|
windows\target\release\*.exe | ||
windows\target\release\*.msi | ||
windows\target\release\*.appx | ||
!**/*~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need all these exclusions? Are the 3 includes above not sufficient?
script: |- | ||
const fs = require('fs').promises | ||
const path = require('path') | ||
const patterns = "windows/target/update/changelog.*,!**/*~,!**/#*#,!**/.#*,!**/%*%,!**/._*,!**/CVS,!**/CVS/**,!**/.cvsignore,!**/SCCS,!**/SCCS/**,!**/vssver.scc,!**/.svn,!**/.svn/**,!**/.DS_Store,!**/.git,!**/.git/**,!**/.gitattributes,!**/.gitignore,!**/.gitmodules,!**/.hg,!**/.hg/**,!**/.hgignore,!**/.hgsub,!**/.hgsubstate,!**/.hgtags,!**/.bzr,!**/.bzr/**,!**/.bzrignore" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here with all the excludes. If not necessary the entire transfer task and ssh setup could be simplified using https://github.com/appleboy/scp-action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we can dogfood Cyberduck CLI here. We have a Cyberduck CLI Github Action 1 to transfer artifacts. Documentation can be found in the README 2 and sample usage in our connection profiles synchronization with S3 3.
@AliveDevil May assist here when in doubt.
Footnotes
with: | ||
servers: | | ||
[{ | ||
"id": "maven.iterate.ch-release", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maven.iterate
repositories not necessary for Cyberduck builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be reverted before merge.
Migration Jenkins-Pipeline Cyberduck-Realese-Windows-Chocolatey