-
Notifications
You must be signed in to change notification settings - Fork 117
Remove the restriction on dependency for huggingface_hub #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes the version restriction on huggingface_hub in pyproject.toml and reverts the previous change that disabled the SQLAlchemy docs plugin in mkdocs configuration. Flow diagram for mkdocs plugin configuration changeflowchart TD
A[mkdocs.yml] --> B[plugins]
B --> C[SQLAlchemy docs plugin enabled]
C --> D[SSL certificate issue noted]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @amritghimire - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1286 +/- ##
==========================================
- Coverage 88.76% 87.98% -0.78%
==========================================
Files 155 155
Lines 14087 13857 -230
Branches 1982 1934 -48
==========================================
- Hits 12504 12192 -312
- Misses 1122 1190 +68
- Partials 461 475 +14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Possible cause: pytorch/audio#3902 (comment) |
c5c8e2c
to
19a97c3
Compare
Deploying datachain-documentation with
|
Latest commit: |
b1f5a5e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://d3b5d3eb.datachain-documentation.pages.dev |
Branch Preview URL: | https://amrit-retry-failure.datachain-documentation.pages.dev |
for more information, see https://pre-commit.ci
55628a5
to
b50923a
Compare
b50923a
to
b1f5a5e
Compare
This removes the restriction and changes to fix and revert the changes made in #1265
Summary by Sourcery
Remove the version restriction on huggingface_hub dependency and restore SQLAlchemy documentation indexing in the MkDocs configuration.
Enhancements:
<0.34.0
version cap on the huggingface_hub dependency