Skip to content

Remove the restriction on dependency for huggingface_hub #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

amritghimire
Copy link
Contributor

@amritghimire amritghimire commented Aug 11, 2025

This removes the restriction and changes to fix and revert the changes made in #1265

Summary by Sourcery

Remove the version restriction on huggingface_hub dependency and restore SQLAlchemy documentation indexing in the MkDocs configuration.

Enhancements:

  • Remove the <0.34.0 version cap on the huggingface_hub dependency
  • Uncomment the SQLAlchemy objects.inv entry to re-enable its documentation in MkDocs

Copy link
Contributor

sourcery-ai bot commented Aug 11, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes the version restriction on huggingface_hub in pyproject.toml and reverts the previous change that disabled the SQLAlchemy docs plugin in mkdocs configuration.

Flow diagram for mkdocs plugin configuration change

flowchart TD
    A[mkdocs.yml] --> B[plugins]
    B --> C[SQLAlchemy docs plugin enabled]
    C --> D[SSL certificate issue noted]
Loading

File-Level Changes

Change Details Files
Removed version constraint for huggingface_hub dependency
  • Deleted '<0.34.0' version cap
  • Left huggingface_hub unbounded in pyproject.toml dependencies
pyproject.toml
Re-enabled SQLAlchemy docs plugin in mkdocs
  • Uncommented the SQLAlchemy objects.inv entry
  • Restored the docs.sqlalchemy.org plugin reference
mkdocs.yml

Possibly linked issues

  • Fix CI failure #1265: PR removes the huggingface_hub dependency restriction, directly addressing the issue's goal to fix CI.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @amritghimire - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.98%. Comparing base (c15498d) to head (55628a5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
- Coverage   88.76%   87.98%   -0.78%     
==========================================
  Files         155      155              
  Lines       14087    13857     -230     
  Branches     1982     1934      -48     
==========================================
- Hits        12504    12192     -312     
- Misses       1122     1190      +68     
- Partials      461      475      +14     
Flag Coverage Δ
datachain 87.98% <ø> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amritghimire
Copy link
Contributor Author

Possible cause: pytorch/audio#3902 (comment)

@shcheklein shcheklein force-pushed the amrit/retry-failure branch from c5c8e2c to 19a97c3 Compare August 12, 2025 01:00
Copy link

cloudflare-workers-and-pages bot commented Aug 12, 2025

Deploying datachain-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: b1f5a5e
Status: ✅  Deploy successful!
Preview URL: https://d3b5d3eb.datachain-documentation.pages.dev
Branch Preview URL: https://amrit-retry-failure.datachain-documentation.pages.dev

View logs

@shcheklein shcheklein force-pushed the amrit/retry-failure branch 2 times, most recently from 55628a5 to b50923a Compare August 20, 2025 02:27
@shcheklein shcheklein force-pushed the amrit/retry-failure branch from b50923a to b1f5a5e Compare August 20, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants