Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove xfail #75

Closed
wants to merge 1 commit into from
Closed

tests: remove xfail #75

wants to merge 1 commit into from

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Dec 28, 2023

fsspec/adlfs#333 has been merged and released.

fsspec/adlfs#333 has been merged and released.
Copy link
Contributor

github-actions bot commented Mar 4, 2024


------------------------------------------------------------------------ benchmark 'test_sharing_azure-add': 3 tests ------------------------------------------------------------------------
Name (time in s)                      Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_azure-add[2.58.2]     3.5435 (1.05)     3.5435 (1.05)     3.5435 (1.05)     0.0000 (1.0)      3.5435 (1.05)     0.0000 (1.0)           0;0  0.2822 (0.95)          1           1
test_sharing_azure-add[3.10.0]     3.5527 (1.05)     3.5527 (1.05)     3.5527 (1.05)     0.0000 (1.0)      3.5527 (1.05)     0.0000 (1.0)           0;0  0.2815 (0.95)          1           1
test_sharing_azure-add[main]       3.3733 (1.0)      3.3733 (1.0)      3.3733 (1.0)      0.0000 (1.0)      3.3733 (1.0)      0.0000 (1.0)           0;0  0.2964 (1.0)           1           1
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------ benchmark 'test_sharing_azure-add-noop': 3 tests ------------------------------------------------------------------------
Name (time in s)                           Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_azure-add-noop[2.58.2]     2.3670 (1.05)     2.3670 (1.05)     2.3670 (1.05)     0.0000 (1.0)      2.3670 (1.05)     0.0000 (1.0)           0;0  0.4225 (0.95)          1           1
test_sharing_azure-add-noop[3.10.0]     2.4766 (1.10)     2.4766 (1.10)     2.4766 (1.10)     0.0000 (1.0)      2.4766 (1.10)     0.0000 (1.0)           0;0  0.4038 (0.91)          1           1
test_sharing_azure-add-noop[main]       2.2508 (1.0)      2.2508 (1.0)      2.2508 (1.0)      0.0000 (1.0)      2.2508 (1.0)      0.0000 (1.0)           0;0  0.4443 (1.0)           1           1
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------ benchmark 'test_sharing_azure-checkout': 3 tests ------------------------------------------------------------------------
Name (time in s)                           Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_azure-checkout[2.58.2]     1.7329 (1.28)     1.7329 (1.28)     1.7329 (1.28)     0.0000 (1.0)      1.7329 (1.28)     0.0000 (1.0)           0;0  0.5771 (0.78)          1           1
test_sharing_azure-checkout[3.10.0]     2.3717 (1.75)     2.3717 (1.75)     2.3717 (1.75)     0.0000 (1.0)      2.3717 (1.75)     0.0000 (1.0)           0;0  0.4216 (0.57)          1           1
test_sharing_azure-checkout[main]       1.3588 (1.0)      1.3588 (1.0)      1.3588 (1.0)      0.0000 (1.0)      1.3588 (1.0)      0.0000 (1.0)           0;0  0.7360 (1.0)           1           1
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

---------------------------------------------------------------------------- benchmark 'test_sharing_azure-checkout-noop': 3 tests ----------------------------------------------------------------------------
Name (time in ms)                                 Min                 Max                Mean            StdDev              Median               IQR            Outliers     OPS            Rounds  Iterations
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_azure-checkout-noop[2.58.2]     554.3541 (1.00)     554.3541 (1.00)     554.3541 (1.00)     0.0000 (1.0)      554.3541 (1.00)     0.0000 (1.0)           0;0  1.8039 (1.00)          1           1
test_sharing_azure-checkout-noop[3.10.0]     603.7270 (1.09)     603.7270 (1.09)     603.7270 (1.09)     0.0000 (1.0)      603.7270 (1.09)     0.0000 (1.0)           0;0  1.6564 (0.91)          1           1
test_sharing_azure-checkout-noop[main]       551.8436 (1.0)      551.8436 (1.0)      551.8436 (1.0)      0.0000 (1.0)      551.8436 (1.0)      0.0000 (1.0)           0;0  1.8121 (1.0)           1           1
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------ benchmark 'test_sharing_azure-fetch': 3 tests ------------------------------------------------------------------------
Name (time in s)                        Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_azure-fetch[2.58.2]     2.5620 (1.38)     2.5620 (1.38)     2.5620 (1.38)     0.0000 (1.0)      2.5620 (1.38)     0.0000 (1.0)           0;0  0.3903 (0.72)          1           1
test_sharing_azure-fetch[3.10.0]     2.9702 (1.60)     2.9702 (1.60)     2.9702 (1.60)     0.0000 (1.0)      2.9702 (1.60)     0.0000 (1.0)           0;0  0.3367 (0.62)          1           1
test_sharing_azure-fetch[main]       1.8538 (1.0)      1.8538 (1.0)      1.8538 (1.0)      0.0000 (1.0)      1.8538 (1.0)      0.0000 (1.0)           0;0  0.5394 (1.0)           1           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

---------------------------------------------------------------------------- benchmark 'test_sharing_azure-fetch-noop': 3 tests ----------------------------------------------------------------------------
Name (time in ms)                              Min                 Max                Mean            StdDev              Median               IQR            Outliers     OPS            Rounds  Iterations
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_azure-fetch-noop[2.58.2]     417.7608 (1.0)      417.7608 (1.0)      417.7608 (1.0)      0.0000 (1.0)      417.7608 (1.0)      0.0000 (1.0)           0;0  2.3937 (1.0)           1           1
test_sharing_azure-fetch-noop[3.10.0]     495.2568 (1.19)     495.2568 (1.19)     495.2568 (1.19)     0.0000 (1.0)      495.2568 (1.19)     0.0000 (1.0)           0;0  2.0192 (0.84)          1           1
test_sharing_azure-fetch-noop[main]       842.1786 (2.02)     842.1786 (2.02)     842.1786 (2.02)     0.0000 (1.0)      842.1786 (2.02)     0.0000 (1.0)           0;0  1.1874 (0.50)          1           1
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------ benchmark 'test_sharing_azure-push': 3 tests ------------------------------------------------------------------------
Name (time in s)                       Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_azure-push[2.58.2]     2.0928 (1.41)     2.0928 (1.41)     2.0928 (1.41)     0.0000 (1.0)      2.0928 (1.41)     0.0000 (1.0)           0;0  0.4778 (0.71)          1           1
test_sharing_azure-push[3.10.0]     1.9138 (1.29)     1.9138 (1.29)     1.9138 (1.29)     0.0000 (1.0)      1.9138 (1.29)     0.0000 (1.0)           0;0  0.5225 (0.78)          1           1
test_sharing_azure-push[main]       1.4844 (1.0)      1.4844 (1.0)      1.4844 (1.0)      0.0000 (1.0)      1.4844 (1.0)      0.0000 (1.0)           0;0  0.6737 (1.0)           1           1
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

---------------------------------------------------------------------------- benchmark 'test_sharing_azure-push-noop': 3 tests ----------------------------------------------------------------------------
Name (time in ms)                             Min                 Max                Mean            StdDev              Median               IQR            Outliers     OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_azure-push-noop[2.58.2]     470.5561 (1.08)     470.5561 (1.08)     470.5561 (1.08)     0.0000 (1.0)      470.5561 (1.08)     0.0000 (1.0)           0;0  2.1251 (0.92)          1           1
test_sharing_azure-push-noop[3.10.0]     433.7850 (1.0)      433.7850 (1.0)      433.7850 (1.0)      0.0000 (1.0)      433.7850 (1.0)      0.0000 (1.0)           0;0  2.3053 (1.0)           1           1
test_sharing_azure-push-noop[main]       825.3954 (1.90)     825.3954 (1.90)     825.3954 (1.90)     0.0000 (1.0)      825.3954 (1.90)     0.0000 (1.0)           0;0  1.2115 (0.53)          1           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@@ -28,7 +28,6 @@ def workspace(make_workspace):
return make_workspace(name="workspace", typ="azure")


@pytest.mark.xfail(reason="waiting for https://github.com/fsspec/adlfs/pull/333")
class TestImport(_TestImport):
@pytest.fixture
def stage_md5(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like etags are not stable in azurite between sucessive runs.

@skshetry
Copy link
Member

skshetry commented Mar 6, 2024

Closing, as we will likely need to change the test framework to remove xfail.

@skshetry skshetry closed this Mar 6, 2024
@skshetry skshetry deleted the efiop-patch-5 branch March 6, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants