Skip to content

Commit

Permalink
osxpkg: fix and test PKG type marker (#160)
Browse files Browse the repository at this point in the history
  • Loading branch information
efiop authored Oct 13, 2023
1 parent 9ed44bf commit c16f404
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ jobs:
- name: Download dvc pkg
run: python download.py

- name: Set pkg type
run: echo 'PKG = "osxpkg"' > dvc/dvc/_build.py

- name: Install dvc requirements
run: |
# available lxml (webdav dependency) wheels are built with an old
Expand All @@ -54,11 +57,10 @@ jobs:
pip install PyInstaller==5.9.0
# https://github.com/iterative/dvc/issues/9654
pip install flufl-lock==7.1.1
dvc doctor
- name: Build binary
run: |
echo 'PKG = "osxpkg"' > dvc/dvc/utils/build.py
python build_bin.py
run: python build_bin.py

- name: Sign binary
run: python sign_bin.py --application-id 62687162A75C39558A9EA17B57E8C65306BABE92 --keychain build.keychain
Expand Down
1 change: 1 addition & 0 deletions build_bin.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,6 @@
]

print(out)
assert "(osxpkg)" in out.splitlines()[0]
for remote in remotes:
assert f"\t{remote}" in out, f"Missing support for {remote}"

0 comments on commit c16f404

Please sign in to comment.