Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link-check to 0.8 for ref link support #2599

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Update link-check to 0.8 for ref link support #2599

merged 1 commit into from
Jul 2, 2021

Conversation

rogermparent
Copy link
Contributor

@rogermparent rogermparent commented Jul 1, 2021 •
edited by jorgeorpinel
Loading

@shcheklein shcheklein temporarily deployed to dvc-org-link-check-0-8-uxh68xv July 1, 2021 15:27 Inactive
jorgeorpinel
jorgeorpinel previously approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this 🚀

Will try on #2534

@jorgeorpinel jorgeorpinel dismissed their stale review July 1, 2021 18:56

Hmmm wait. The check is failing. Can't find v0.8 yet?

@jorgeorpinel
Copy link
Contributor

Hmmm wait. The check is failing. Can't find v0.8 yet?

Cc @rogermparent see https://github.com/iterative/dvc.org/pull/2599/checks?check_run_id=2965875118

@rogermparent
Copy link
Contributor Author

rogermparent commented Jul 1, 2021 •
edited
Loading

Oops! I pushed the link-check commit but not the tag (haven't done this in a while). Will fix ASAP and report back.

@rogermparent
Copy link
Contributor Author

Alright, tag's pushed and CI went through!

@rogermparent rogermparent requested a review from jorgeorpinel July 2, 2021 01:22
@jorgeorpinel jorgeorpinel merged commit cb14045 into master Jul 2, 2021
@shcheklein shcheklein deleted the link-check-0.8 branch July 23, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeorpinel jorgeorpinel jorgeorpinel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rogermparent @jorgeorpinel @shcheklein