index: data: support imports #9181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9181 +/- ##
==========================================
- Coverage 92.91% 92.66% -0.25%
==========================================
Files 456 456
Lines 36884 36886 +2
Branches 5324 5324
==========================================
- Hits 34269 34181 -88
- Misses 2091 2162 +71
- Partials 524 543 +19
... and 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
2 tasks
efiop
force-pushed
the
fetch-import-index
branch
from
f074bf7 to
eff2999
Compare
Stepping stone to simplifying `dvc fetch/pull` by using index. Fetch handles regular imports through index already, but not repo imports because their processing is much more involved (e.g. chained imports) in the current arch. With `FileStorage` support introduced into `DataIndex` and `datafs` supporting imports overall, `dvcfs` can now handle repo imports (even chained ones). This will soon allow us to handle repo imports the same way we handle regular ones, improve performance and get rid of a lot of messy code (e.g. DependencyRepo). Related iterative/scmrepo#207 Related iterative/dvc-data#315 Related https://github.com/iterative/studio/issues/5261
efiop
force-pushed
the
fetch-import-index
branch
from
eff2999 to
6927b3d
Compare
efiop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stepping stone to simplifying
dvc fetch/pullby using index.Fetch handles regular imports through index already, but not repo imports because their processing is much more involved (e.g. chained imports) in the current arch.
With
FileStoragesupport introduced intoDataIndexanddatafssupporting imports overall,dvcfscan now handle repo imports (even chained ones). This will soon allow us to handle repo imports the same way we handle regular ones, improve performance and get rid of a lot of messy code (e.g. DependencyRepo).Related iterative/scmrepo#207
Related iterative/dvc-data#315
Related https://github.com/iterative/studio/issues/5261