artifacts: Bring back name_is_compatible.
#9972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
efiop
reviewed
Sep 25, 2023
| @@ -38,6 +38,17 @@ def check_name_format(name: str) -> None: | |||
| ) from exc | |||
|
|
|||
|
|
|||
| def name_is_compatible(name: str) -> bool: | |||
| from gto.constants import assert_name_is_valid | |||
There was a problem hiding this comment.
Was it only importing it or using also? If the former then a noop stub should do. But either way need a comment here with a link so we know this is only kept because of dvclive and can drop it later.
There was a problem hiding this comment.
Was it only importing it or using also?
Actually using
pmrowla
approved these changes
Sep 26, 2023
Unfortunately, DVCLive was importing this function so I am bringing back the name for backwards compatibility.
efiop
force-pushed
the
name-is-compatible
branch
from
b6065ce to
71cb7a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, DVCLive was importing this function so I am bringing back the name for backwards compatibility.
See iterative/dvclive#715