Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local variable 'last_metrics' referenced before assignment #852

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

mluscon
Copy link
Contributor

@mluscon mluscon commented Dec 18, 2024

This happens on line :132 in case of handled exception in the first iteration of the loop.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (602c053) to head (ca121ed).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   95.47%   95.29%   -0.18%     
==========================================
  Files          57       55       -2     
  Lines        3889     3911      +22     
  Branches      353      304      -49     
==========================================
+ Hits         3713     3727      +14     
- Misses        124      138      +14     
+ Partials       52       46       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shcheklein shcheklein merged commit 6bce4fa into iterative:main Dec 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants