Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ray): Add Ray to Studio chart #123

Merged
merged 14 commits into from
Aug 17, 2023
Merged

feat(ray): Add Ray to Studio chart #123

merged 14 commits into from
Aug 17, 2023

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Jul 17, 2023 •
edited
Loading

mjasion
mjasion suggested changes Jul 17, 2023
View reviewed changes
charts/studio/values.yaml Outdated Show resolved Hide resolved
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jul 19, 2023
@mjasion mjasion mentioned this pull request Jul 25, 2023
Draft
@0x2b3bfa0 0x2b3bfa0 force-pushed the ray-chart branch 2 times, most recently from 382cb04 to 3463c05 Compare August 16, 2023 02:06
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review August 16, 2023 02:09
@0x2b3bfa0 0x2b3bfa0 requested a review from mjasion August 16, 2023 02:09
@0x2b3bfa0
Copy link
Member Author

Why the lint-test workflow is failing

Error: UPGRADE FAILED: template: studio/templates/raycluster-studio.yaml:1:14: executing "studio/templates/raycluster-studio.yaml" at <.Values.ray.enabled>: nil pointer evaluating interface {}.enabled

@0x2b3bfa0 0x2b3bfa0 requested a review from a team August 16, 2023 20:50
@0x2b3bfa0
Copy link
Member Author

@iterative/platform, would you mind if I merge this as-is and debug it after the fact?

@0x2b3bfa0
Copy link
Member Author

Regardless, please review it for sanity.

mjasion
mjasion reviewed Aug 17, 2023
View reviewed changes
charts/studio/values.yaml Outdated Show resolved Hide resolved
charts/studio/values.yaml Outdated Show resolved Hide resolved
charts/studio/templates/raycluster-studio.yaml Show resolved Hide resolved
@mjasion mjasion changed the title Add Ray to Studio chart feat(ray): Add Ray to Studio chart Aug 17, 2023
@mjasion
Copy link
Contributor

mjasion commented Aug 17, 2023

@0x2b3bfa0

  1. Can you bump version to 0.4.0 - I think this is minor, patch

0x2b3bfa0 and others added 2 commits August 17, 2023 13:19
jesper7
jesper7 suggested changes Aug 17, 2023
View reviewed changes
charts/studio/README.md Show resolved Hide resolved
@0x2b3bfa0 0x2b3bfa0 requested a review from jesper7 August 17, 2023 12:02
@0x2b3bfa0 0x2b3bfa0 enabled auto-merge August 17, 2023 13:48
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Aug 17, 2023
Open
@0x2b3bfa0 0x2b3bfa0 added this pull request to the merge queue Aug 17, 2023
Merged via the queue into main with commit 0b68840 Aug 17, 2023
@0x2b3bfa0 0x2b3bfa0 deleted the ray-chart branch August 17, 2023 14:07
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omesser omesser omesser left review comments

@jesper7 jesper7 jesper7 approved these changes

@mjasion mjasion mjasion approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0x2b3bfa0 @mjasion @omesser @jesper7