Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toml and yaml formatters to pre-commit #121

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

AlexandreKempf
Copy link
Contributor

@AlexandreKempf AlexandreKempf commented Feb 8, 2024

Context: iterative/dvclive#773 (comment)
Format was not enforced for TOML and YAML files.

@dberenbaum dberenbaum requested a review from a team February 8, 2024 18:14
@dberenbaum
Copy link

Could you also apply the changes to the pyproject.toml template? Otherwise I assume it will have to be reformatted each time once the project is generated.

@AlexandreKempf
Copy link
Contributor Author

That is a very good point, @dberenbaum!
I formatted the files and tried it on my computer. Everything is well formatted at repo initialization.
image

@AlexandreKempf AlexandreKempf merged commit e4ec95f into main Feb 9, 2024
2 checks passed
@skshetry skshetry deleted the precommit-toml-yaml-formatters branch March 6, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants