Solve the url change problem in pygit2 fetch_refspec
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because for now `pygit2` fetch didn't support `file://` format on Windows, we removed this prefix. But didn't add it back after the fetch operation finished, and it makes the following `dulwich` backend goes wrong. So here in the PR, we always create a new remote and delete it after the operation to make the remote config unchanged after the operation.
|
This is probably another indicator that we should really be using |
pmrowla
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because for now
pygit2fetch didn't supportfile://format on Windows, we removed this prefix. But didn't add it back after the fetch operation finished, and it makes the followingdulwichbackend goes wrong.So here in the PR, we always create a new remote and delete it after the operation to make the remote config unchanged after the operation. Can be removed after #176 solved.
Related to the CI failure in https://github.com/iterative/dvc/actions/runs/4082287489/jobs/7037469526#logs