Add error message to "Data Series" section #5152
Conversation
julieg18
changed the title
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| import { TemplatePlots } from './TemplatePlots' | ||
| import { PlotsContainer } from '../PlotsContainer' | ||
| import { PlotsState } from '../../store' | ||
|
|
||
| export const TemplatePlotsWrapper: React.FC = () => { | ||
| const { nbItemsPerRow, isCollapsed, height, hasItems } = useSelector( | ||
| const { nbItemsPerRow, isCollapsed, height, hasItems, errors } = useSelector( |
There was a problem hiding this comment.
Similar blocks of code found in 6 locations. Consider refactoring.
| </th> | ||
| </tr> | ||
| {revs.map(({ rev, msg }) => ( | ||
| <tr key={rev}> |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 547cafd and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 78.9% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (-0.1% change). View more on Code Climate. |
Figured out the issue. We actually don't know what type a plot is unless it's built at least once in the current session. If the user starts a new session or reloads the window with a broken plot, the extension will not know the broken plot type and we can't show the error in the Screen.Recording.2024-01-02.at.6.07.36.PM.movOne option to fix this is to show the error messaging above the sections below the ribbon: 
We also could just leave it as is but it seems buggy 🤔 Any other ideas? cc @iterative/vs-code, @shcheklein |
Going to open a new pr that adds the error message above the sections and close this one for now. We could at least have a generic error message above all sections as a first iteration and come back to this later if we find a solution for the bug. |
Demo
Screen.Recording.2024-01-02.at.11.59.09.AM.mov
To Do
Part of #5087