fix: remove build section for docker compose #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker compose will ignore any build section in docker-compose.yml if image section is specified, unlike the deprecated docker-compose. And the build section is not needed anyway. The docker-compose.test.yml will very likely not work with docker compose because of image and build section specified together. That PR does not remove the wrong image section in it. Signed-off-by: Jérôme Benoit <[email protected]>
|
What is the alternative for custom file then ? |
If you need to include image customisation with The docker-compose.xml does not need to install the testing requirements to run NFIX. It's only needed in the testing docker-compose-... file. The CI is using (incorrectly) direct image building from the docker file Dockerfile.custom instead of docker compose probably because docker compose was failing at including the testing requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker compose will ignore any build section in docker-compose.yml if image section is specified, unlike the deprecated docker-compose. And the build section is not needed anyway.
The docker-compose.test.yml will very likely not work with docker compose because of image and build section specified together. That PR does not remove the wrong image section in it.