Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install payload delay #134

Merged
merged 7 commits into from
Jan 22, 2025
Merged

feat: install payload delay #134

merged 7 commits into from
Jan 22, 2025

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Jan 22, 2025

this adds a hack that wraps the engine_getPayloadV3 and applies a delay, that delays the request up to 500ms into the slot.

the motivation for this is, so we can give the payload builder a bit more time to include more txs, because the previous block building window was observed to be ~250ms

@mattsse mattsse force-pushed the matt/add-delayed-resolver branch from 79a7833 to 3069865 Compare January 22, 2025 10:46
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im a bit wary of merging with the chain advancement test failing, can you verify that it is still advancing and the test might just be flaky?

@onbjerg onbjerg enabled auto-merge (squash) January 22, 2025 13:43
@onbjerg onbjerg merged commit 5fc8fe8 into main Jan 22, 2025
14 checks passed
@onbjerg onbjerg deleted the matt/add-delayed-resolver branch January 22, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants