New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve error handling in DelayedResolver::into_rpc_module #143

Open

avorylli wants to merge 1 commit into ithacaxyz:main from avorylli:main

avorylli commented Feb 10, 2025

Change into_rpc_module to return Result instead of unwrap()
Add error documentation
Update tests to properly handle errors


          Update delayed_resolve.rs

c975210

avorylli requested review from onbjerg, Rjected and mattsse as code owners

February 10, 2025 01:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Rjected Awaiting requested review from Rjected Rjected is a code owner

mattsse Awaiting requested review from mattsse mattsse is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet