сhore: use upstream kurtosis package #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenpaff
reviewed
Oct 19, 2024
| - name: Build Odyssey | ||
| run: docker buildx build . --load -t ghcr.io/ithacaxyz/odyssey:latest | ||
| - name: Run enclave | ||
| id: kurtosis | ||
| run: | | ||
| git clone https://github.com/klkvr/optimism-package |
There was a problem hiding this comment.
why do we still need to use your optimism-package fork?
There was a problem hiding this comment.
once ethpandaops/optimism-package#85 is merged there would be no need for it, can hold off this PR until it's merged
There was a problem hiding this comment.
ah got it, no need to wait- we can just change it later was just curious
onbjerg
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses ethpandaops/optimism-package#85 for now, once merged can be replaced with upstream package.
This also switches to using images from https://github.com/paradigmxyz/optimism cc @Rjected